RE: [MI] Duplicate --thread-group flag not detected

[Marc Khouzam <marc.khouzam@ericsson.com>]

> > I think in this case the patch is simple and obvious enough that we can
> > go forward without waiting.
> >
> > What do you think of that?
> 
> Agreed. I am also OK for the 7.2 branch, even if it's not exactly
> a critical bug.

So, I can commit to both branches?  Even without the new test?
I apologize, but I just don't have time to write new tests, because I know
that if I start, I'll make sure every case is tested, and that will take
more time than I have for a bug that is not really that important.

I'll wait for you go/no-go to commit.

> > I was curious about this -- is this sort of transition something people
> > would want to see done?  Would it help MI users?  (It would help Python
> > if we ever implemented the automatic MI wrapping... but I am not sure
> > whether we really want to do that.)
> 
> I hope others have enough experience with MI that we can have some
> useful answers. I don't have much experience with MI myself...

I'm personally not familiar with what you mean with "new style argv commands",
so I can't and anything to that.


2010-12-04  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-parse.c (mi_parse): Missing else.

### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21
diff -u -r1.21 mi-parse.c
--- gdb/mi/mi-parse.c   17 May 2010 20:49:39 -0000      1.21
+++ gdb/mi/mi-parse.c   25 Nov 2010 20:43:31 -0000
@@ -319,7 +319,7 @@
          chp += 1;
          parse->thread_group = strtol (chp, &chp, 10);
        }
-      if (strncmp (chp, "--thread ", ts) == 0)
+      else if (strncmp (chp, "--thread ", ts) == 0)
        {
          if (parse->thread != -1)
            error (_("Duplicate '--thread' option"));