From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19090 invoked by alias); 4 Dec 2010 18:10:29 -0000 Received: (qmail 19081 invoked by uid 22791); 4 Dec 2010 18:10:28 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,TW_RG X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 04 Dec 2010 18:10:21 +0000 Received: from eusaamw0712.eamcs.ericsson.se ([147.117.20.181]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oB4IcZJu007518; Sat, 4 Dec 2010 12:38:36 -0600 Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.63]) by eusaamw0712.eamcs.ericsson.se ([147.117.20.181]) with mapi; Sat, 4 Dec 2010 13:09:40 -0500 From: Marc Khouzam To: Joel Brobecker , Tom Tromey CC: "'gdb-patches@sourceware.org'" Date: Sat, 04 Dec 2010 18:10:00 -0000 Subject: RE: [MI] Duplicate --thread-group flag not detected Message-ID: References: <20101126163842.GJ2634@adacore.com> ,<20101202170954.GA3031@adacore.com> In-Reply-To: <20101202170954.GA3031@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00029.txt.bz2 > > I think in this case the patch is simple and obvious enough that we can > > go forward without waiting. > > > > What do you think of that? >=20 > Agreed. I am also OK for the 7.2 branch, even if it's not exactly > a critical bug. So, I can commit to both branches? Even without the new test? I apologize, but I just don't have time to write new tests, because I know that if I start, I'll make sure every case is tested, and that will take more time than I have for a bug that is not really that important. I'll wait for you go/no-go to commit. > > I was curious about this -- is this sort of transition something people > > would want to see done? Would it help MI users? (It would help Python > > if we ever implemented the automatic MI wrapping... but I am not sure > > whether we really want to do that.) >=20 > I hope others have enough experience with MI that we can have some > useful answers. I don't have much experience with MI myself... I'm personally not familiar with what you mean with "new style argv command= s", so I can't and anything to that. 2010-12-04 Marc Khouzam * mi/mi-parse.c (mi_parse): Missing else. ### Eclipse Workspace Patch 1.0 #P src Index: gdb/mi/mi-parse.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v retrieving revision 1.21 diff -u -r1.21 mi-parse.c --- gdb/mi/mi-parse.c 17 May 2010 20:49:39 -0000 1.21 +++ gdb/mi/mi-parse.c 25 Nov 2010 20:43:31 -0000 @@ -319,7 +319,7 @@ chp +=3D 1; parse->thread_group =3D strtol (chp, &chp, 10); } - if (strncmp (chp, "--thread ", ts) =3D=3D 0) + else if (strncmp (chp, "--thread ", ts) =3D=3D 0) { if (parse->thread !=3D -1) error (_("Duplicate '--thread' option"));