From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76804-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16106 invoked by alias); 6 Dec 2010 14:26:49 -0000
Received: (qmail 16098 invoked by uid 22791); 6 Dec 2010 14:26:48 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.8)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Dec 2010 14:26:43 +0000
Received: from eusaamw0712.eamcs.ericsson.se ([147.117.20.181])	by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oB6EtL51001740;	Mon, 6 Dec 2010 08:55:25 -0600
Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.63]) by eusaamw0712.eamcs.ericsson.se ([147.117.20.181]) with mapi; Mon, 6 Dec 2010 09:26:07 -0500
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'Joel Brobecker'" <brobecker@adacore.com>
CC: "'Tom Tromey'" <tromey@redhat.com>,        "'gdb-patches@sourceware.org'"	<gdb-patches@sourceware.org>
Date: Mon, 06 Dec 2010 14:26:00 -0000
Subject: RE: [MI] Duplicate --thread-group flag not detected
Message-ID: <F7CE05678329534C957159168FA70DEC572E8BFB79@EUSAACMS0703.eamcs.ericsson.se>
References: <F7CE05678329534C957159168FA70DEC572E7598F3@EUSAACMS0703.eamcs.ericsson.se> <20101126163842.GJ2634@adacore.com> <m3bp54ku1x.fsf@fleche.redhat.com> <20101202170954.GA3031@adacore.com> <F7CE05678329534C957159168FA70DEC572E0C0DDC@EUSAACMS0703.eamcs.ericsson.se> <20101204184638.GB3031@adacore.com> <F7CE05678329534C957159168FA70DEC572E0C0DDE@EUSAACMS0703.eamcs.ericsson.se> <20101206110417.GC3031@adacore.com>
In-Reply-To: <20101206110417.GC3031@adacore.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00049.txt.bz2

=20

> -----Original Message-----
> From: Joel Brobecker [mailto:brobecker@adacore.com]=20
> Sent: Monday, December 06, 2010 6:04 AM
> To: Marc Khouzam
> Cc: Tom Tromey; 'gdb-patches@sourceware.org'
> Subject: Re: [MI] Duplicate --thread-group flag not detected
>=20
> > You make it hard to say no :-)
>=20
> :-D
>=20
> > So here's my attempt at new tests for these cases.  I wasn't sure
> > where to put it so I created a new mi-general.exp test which should
> > eventually test the parsing of general MI syntax, including the
> > --thread-group, --thread, --frame, --all, --reverse, flags.
>=20
> OK. I propose we treat this patch as separate. Please just go ahead
> with the code part, while we review the testing part.

I'll email separately for the testcase then.

I committed the code part to HEAD and 7_2

2010-12-06  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-parse.c (mi_parse): Missing else.
=20=20=20=20=20=20=20=20
### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21
diff -u -r1.21 mi-parse.c
--- gdb/mi/mi-parse.c   17 May 2010 20:49:39 -0000      1.21
+++ gdb/mi/mi-parse.c   5 Dec 2010 19:07:26 -0000
@@ -319,7 +319,7 @@
          chp +=3D 1;
          parse->thread_group =3D strtol (chp, &chp, 10);
        }
-      if (strncmp (chp, "--thread ", ts) =3D=3D 0)
+      else if (strncmp (chp, "--thread ", ts) =3D=3D 0)
        {
          if (parse->thread !=3D -1)
            error (_("Duplicate '--thread' option"));