From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Eli Zaretskii'" <eliz@gnu.org>, <gdb-patches@sourceware.org>
Subject: Re: [RFA-v2] Fix ARI warning about function call in first column
Date: Mon, 14 Mar 2011 17:39:00 -0000 [thread overview]
Message-ID: <m3bp1dd3kl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <10281.0550401502$1300122152@news.gmane.org> (Pierre Muller's message of "Mon, 14 Mar 2011 18:01:54 +0100")
Eli> I see no problem with long lines, if there are no better alternatives.
I agree. Sometimes there really is no good answer and you just have to
pick the least worst.
Pierre> I hope everyone is OK with this.
Pierre> I think that we do have lots of other occurrences
Pierre> of lines longer than 80 cols anyhow...
It is fine.
Pierre> +static struct varobj * varobj_add_child (struct varobj *var,
Pierre> + const char *name,
Pierre> + struct value *value);
Extra space after the "*".
Pierre> +extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct
Likewise.
Pierre> +struct displaced_step_closure* get_displaced_step_closure_by_addr
Space is on the wrong side of the "*"; I know you didn't cause this but
if you are fixing the indentation anyway...
Tom
next prev parent reply other threads:[~2011-03-14 17:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 2:17 New ARI warning Sat Mar 12 01:53:29 UTC 2011 GDB Administrator
2011-03-13 9:32 ` Pierre Muller
2011-03-13 10:24 ` [RFA] Fix ARI warning about function call in first column (was : New ARI warning Sat Mar 12 01:53:29 UTC 2011) Pierre Muller
2011-03-13 13:42 ` [RFA] Fix ARI warnings about function with no parameters ( " Pierre Muller
2011-03-14 16:03 ` Pierre Muller
2011-03-13 19:39 ` New ARI warning Sat Mar 12 01:53:29 UTC 2011 Eli Zaretskii
2011-03-14 11:26 ` Pierre Muller
2011-03-14 12:13 ` Eli Zaretskii
2011-03-14 12:34 ` Pedro Alves
2011-03-14 12:34 ` Eli Zaretskii
2011-03-14 12:49 ` Pierre Muller
2011-03-14 13:06 ` Eli Zaretskii
2011-03-14 12:51 ` Eli Zaretskii
2011-03-14 12:52 ` Pierre Muller
2011-03-14 13:16 ` Eli Zaretskii
2011-03-14 12:59 ` Pedro Alves
2011-03-14 13:27 ` Eli Zaretskii
2011-03-14 13:46 ` Pedro Alves
2011-03-14 15:46 ` Pierre Muller
2011-03-19 21:15 ` Mark Kettenis
[not found] ` <18667.385276831$1300008680@news.gmane.org>
2011-03-14 15:54 ` [RFA] Fix ARI warning about function call in first column Tom Tromey
2011-03-14 16:46 ` [RFA-v2] " Pierre Muller
2011-03-14 17:02 ` Tom Tromey
[not found] ` <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr>
2011-03-14 17:17 ` Eli Zaretskii
2011-03-14 17:26 ` Pierre Muller
[not found] ` <10281.0550401502$1300122152@news.gmane.org>
2011-03-14 17:39 ` Tom Tromey [this message]
2011-03-15 12:19 ` [RFA] Fix formatting in " Pierre Muller
[not found] ` <45563.9187516228$1300186224@news.gmane.org>
2011-03-15 15:42 ` Tom Tromey
2011-03-15 16:01 ` Pierre Muller
[not found] ` <002001cbe269$85ed0e60$91c72b20$%muller@ics-cnrs.unistra.fr>
2011-03-14 21:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bp1dd3kl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox