Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Cc: pierre.muller@ics-cnrs.unistra.fr
Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011
Date: Mon, 14 Mar 2011 13:46:00 -0000	[thread overview]
Message-ID: <201103141316.17227.pedro@codesourcery.com> (raw)
In-Reply-To: <E1Pz7TM-0000Pw-3x@fencepost.gnu.org>

On Monday 14 March 2011 13:06:08, Eli Zaretskii wrote:
> > I'm fine with your suggestion, and in fact it's my preference
> > as well.  However, there are cases where you just can't do that,
> > because the return type + function name + parameter end up being
> > too long for a single line.
> 
> What's wrong with leaving a single long line in such cases?  They are
> supposed to be very rare (if typedefs are used for complex function
> arguments).

If we have a rule to follow, we should follow it everywhere.
And they are not very rare; we have quite a few cases.  The most
prominent styles are:

/* Find a particular location expression from a location list.  */
const gdb_byte *dwarf2_find_location_expression
  (struct dwarf2_loclist_baton *baton,
   size_t *locexpr_length,
   CORE_ADDR pc);

/* Find an inferior bound to PSPACE.  */
extern struct inferior *
  find_inferior_for_program_space (struct program_space *pspace);

-- 
Pedro Alves


  reply	other threads:[~2011-03-14 13:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12  2:17 GDB Administrator
2011-03-13  9:32 ` Pierre Muller
2011-03-13 10:24   ` [RFA] Fix ARI warning about function call in first column (was : New ARI warning Sat Mar 12 01:53:29 UTC 2011) Pierre Muller
2011-03-13 13:42   ` [RFA] Fix ARI warnings about function with no parameters ( " Pierre Muller
2011-03-14 16:03     ` Pierre Muller
2011-03-13 19:39   ` New ARI warning Sat Mar 12 01:53:29 UTC 2011 Eli Zaretskii
2011-03-14 11:26     ` Pierre Muller
2011-03-14 12:13       ` Eli Zaretskii
2011-03-14 12:34         ` Pedro Alves
2011-03-14 12:34           ` Eli Zaretskii
2011-03-14 12:49           ` Pierre Muller
2011-03-14 13:06             ` Eli Zaretskii
2011-03-14 12:51           ` Eli Zaretskii
2011-03-14 12:52             ` Pierre Muller
2011-03-14 13:16               ` Eli Zaretskii
2011-03-14 12:59             ` Pedro Alves
2011-03-14 13:27               ` Eli Zaretskii
2011-03-14 13:46                 ` Pedro Alves [this message]
2011-03-14 15:46                 ` Pierre Muller
2011-03-19 21:15                   ` Mark Kettenis
     [not found]   ` <18667.385276831$1300008680@news.gmane.org>
2011-03-14 15:54     ` [RFA] Fix ARI warning about function call in first column Tom Tromey
2011-03-14 16:46       ` [RFA-v2] " Pierre Muller
2011-03-14 17:02         ` Tom Tromey
     [not found]       ` <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr>
2011-03-14 17:17         ` Eli Zaretskii
2011-03-14 17:26           ` Pierre Muller
     [not found]           ` <10281.0550401502$1300122152@news.gmane.org>
2011-03-14 17:39             ` Tom Tromey
2011-03-15 12:19               ` [RFA] Fix formatting in " Pierre Muller
     [not found]               ` <45563.9187516228$1300186224@news.gmane.org>
2011-03-15 15:42                 ` Tom Tromey
2011-03-15 16:01                   ` Pierre Muller
     [not found]           ` <002001cbe269$85ed0e60$91c72b20$%muller@ics-cnrs.unistra.fr>
2011-03-14 21:26             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103141316.17227.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox