From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] Fix ARI warning about function call in first column (was : New ARI warning Sat Mar 12 01:53:29 UTC 2011)
Date: Sun, 13 Mar 2011 10:24:00 -0000 [thread overview]
Message-ID: <011501cbe161$5b67fcd0$1237f670$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <010f01cbe157$aebb5cb0$0c321610$@muller@ics-cnrs.unistra.fr>
This second patch fixes:
> gdb/hppa-tdep.h:244: code: function call in first column: Function name in
first column should be restricted to function implementation
gdb/hppa-tdep.h:244:hppa_init_objfile_priv_data (struct objfile *objfile);
and other occurrences of same new warning.
OK to apply?
Pierre Muller
as ARI maintainer.
2011-03-13 Pierre Muller <muller@ics.u-strasbg.fr>
Fix ARI warning about functions without parameters that do not
use (void).
* breakpoint.c (all_tracepoints): Replace () by (void).
* f-exp.y (match_string_literal): Ditto.
(yylex): Ditto.
* m2-exp.y (yylex): Ditto.
* mep-tdep.c (current_me_module): Ditto.
(current_options): Ditto.
(current_cop_data_bus_width): Ditto.
(current_cr_names): Ditto.
(current_cr_is_float): Ditto.
(current_ccr_names): Ditto.
* objc-exp.y (yylex): Ditto.
* p-exp.y (yylex): Ditto.
* remote.c (send_interrupt_sequence): Ditto.
* tracepoint.c (current_trace_status): Ditto.
* python/py-evts.c (gdbpy_initialize_py_events): Ditto.
* python/py-prettyprint.c (push_dummy_python_frame): Ditto.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.550
diff -u -p -r1.550 breakpoint.c
--- breakpoint.c 10 Mar 2011 18:33:59 -0000 1.550
+++ breakpoint.c 11 Mar 2011 15:18:06 -0000
@@ -11952,7 +11952,7 @@ save_tracepoints_command (char *args, in
/* Create a vector of all tracepoints. */
VEC(breakpoint_p) *
-all_tracepoints ()
+all_tracepoints (void)
{
VEC(breakpoint_p) *tp_vec = 0;
struct breakpoint *tp;
Index: f-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/f-exp.y,v
retrieving revision 1.36
diff -u -p -r1.36 f-exp.y
--- f-exp.y 7 Jan 2011 19:36:16 -0000 1.36
+++ f-exp.y 11 Mar 2011 15:18:06 -0000
@@ -919,7 +919,7 @@ growbuf_by_size (count)
a string, it is simply doubled (I.E. 'this''is''one''string') */
static int
-match_string_literal ()
+match_string_literal (void)
{
char *tokptr = lexptr;
@@ -951,7 +951,7 @@ match_string_literal ()
/* Read one token, getting characters through lexptr. */
static int
-yylex ()
+yylex (void)
{
int c;
int namelen;
Index: m2-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/m2-exp.y,v
retrieving revision 1.33
diff -u -p -r1.33 m2-exp.y
--- m2-exp.y 9 Jan 2011 03:20:33 -0000 1.33
+++ m2-exp.y 11 Mar 2011 15:18:06 -0000
@@ -808,7 +808,7 @@ static struct keyword keytab[] =
compatible */
static int
-yylex ()
+yylex (void)
{
int c;
int namelen;
Index: mep-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mep-tdep.c,v
retrieving revision 1.29
diff -u -p -r1.29 mep-tdep.c
--- mep-tdep.c 10 Jan 2011 17:14:12 -0000 1.29
+++ mep-tdep.c 11 Mar 2011 15:18:06 -0000
@@ -845,7 +845,7 @@ mep_pseudo_cr_index (int pseudo)
from the ELF header's e_flags field of the current executable
file. */
static CONFIG_ATTR
-current_me_module ()
+current_me_module (void)
{
if (target_has_registers)
{
@@ -868,7 +868,7 @@ current_me_module ()
then use the 'module_opt' field we computed when we build the
gdbarch object for this module. */
static unsigned int
-current_options ()
+current_options (void)
{
if (target_has_registers)
{
@@ -885,7 +885,7 @@ current_options ()
/* Return the width of the current me_module's coprocessor data bus,
in bits. This is either 32 or 64. */
static int
-current_cop_data_bus_width ()
+current_cop_data_bus_width (void)
{
return me_module_cop_data_bus_width (current_me_module ());
}
@@ -894,7 +894,7 @@ current_cop_data_bus_width ()
/* Return the keyword table of coprocessor general-purpose register
names appropriate for the me_module we're dealing with. */
static CGEN_KEYWORD *
-current_cr_names ()
+current_cr_names (void)
{
const CGEN_HW_ENTRY *hw
= me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);
@@ -906,7 +906,7 @@ current_cr_names ()
/* Return non-zero if the coprocessor general-purpose registers are
floating-point values, zero otherwise. */
static int
-current_cr_is_float ()
+current_cr_is_float (void)
{
const CGEN_HW_ENTRY *hw
= me_module_register_set (current_me_module (), "h-cr-", HW_H_CR);
@@ -918,7 +918,7 @@ current_cr_is_float ()
/* Return the keyword table of coprocessor control register names
appropriate for the me_module we're dealing with. */
static CGEN_KEYWORD *
-current_ccr_names ()
+current_ccr_names (void)
{
const CGEN_HW_ENTRY *hw
= me_module_register_set (current_me_module (), "h-ccr-", HW_H_CCR);
Index: objc-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/objc-exp.y,v
retrieving revision 1.41
diff -u -p -r1.41 objc-exp.y
--- objc-exp.y 10 Jan 2011 20:38:49 -0000 1.41
+++ objc-exp.y 11 Mar 2011 15:18:06 -0000
@@ -1218,7 +1218,7 @@ static const struct token tokentab2[] =
/* Read one token, getting characters through lexptr. */
static int
-yylex ()
+yylex (void)
{
int c, tokchr;
int namelen;
Index: p-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/p-exp.y,v
retrieving revision 1.54
diff -u -p -r1.54 p-exp.y
--- p-exp.y 17 Jan 2011 10:34:51 -0000 1.54
+++ p-exp.y 11 Mar 2011 15:18:06 -0000
@@ -1120,7 +1120,7 @@ static int last_was_structop;
/* Read one token, getting characters through lexptr. */
static int
-yylex ()
+yylex (void)
{
int c;
int namelen;
Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.438
diff -u -p -r1.438 remote.c
--- remote.c 8 Mar 2011 12:46:51 -0000 1.438
+++ remote.c 11 Mar 2011 15:18:07 -0000
@@ -3112,7 +3112,7 @@ struct start_remote_args
/* Send interrupt_sequence to remote target. */
static void
-send_interrupt_sequence ()
+send_interrupt_sequence (void)
{
if (interrupt_sequence_mode == interrupt_sequence_control_c)
serial_write (remote_desc, "\x03", 1);
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.216
diff -u -p -r1.216 tracepoint.c
--- tracepoint.c 10 Mar 2011 18:33:59 -0000 1.216
+++ tracepoint.c 11 Mar 2011 15:18:08 -0000
@@ -218,7 +218,7 @@ char *stop_reason_names[] = {
};
struct trace_status *
-current_trace_status ()
+current_trace_status (void)
{
return &trace_status;
}
Index: python/py-evts.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-evts.c,v
retrieving revision 1.1
diff -u -p -r1.1 py-evts.c
--- python/py-evts.c 5 Feb 2011 05:27:23 -0000 1.1
+++ python/py-evts.c 11 Mar 2011 15:18:08 -0000
@@ -42,7 +42,7 @@ add_new_registry (eventregistry_object *
}
void
-gdbpy_initialize_py_events ()
+gdbpy_initialize_py_events (void)
{
gdb_py_events.module = Py_InitModule ("events", NULL);
Index: python/py-prettyprint.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-prettyprint.c,v
retrieving revision 1.23
diff -u -p -r1.23 py-prettyprint.c
--- python/py-prettyprint.c 1 Mar 2011 21:54:53 -0000 1.23
+++ python/py-prettyprint.c 11 Mar 2011 15:18:08 -0000
@@ -394,7 +394,7 @@ py_restore_tstate (void *p)
/* Create a dummy PyFrameObject, needed to work around
a Python-2.4 bug with generators. */
static PyObject *
-push_dummy_python_frame ()
+push_dummy_python_frame (void)
{
PyObject *empty_string, *null_tuple, *globals;
PyCodeObject *code;
next prev parent reply other threads:[~2011-03-13 9:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 2:17 New ARI warning Sat Mar 12 01:53:29 UTC 2011 GDB Administrator
2011-03-13 9:32 ` Pierre Muller
2011-03-13 10:24 ` Pierre Muller [this message]
2011-03-13 13:42 ` [RFA] Fix ARI warnings about function with no parameters ( RE: New ARI warning Sat Mar 12 01:53:29 UTC 2011) Pierre Muller
2011-03-14 16:03 ` Pierre Muller
2011-03-13 19:39 ` New ARI warning Sat Mar 12 01:53:29 UTC 2011 Eli Zaretskii
2011-03-14 11:26 ` Pierre Muller
2011-03-14 12:13 ` Eli Zaretskii
2011-03-14 12:34 ` Pedro Alves
2011-03-14 12:34 ` Eli Zaretskii
2011-03-14 12:49 ` Pierre Muller
2011-03-14 13:06 ` Eli Zaretskii
2011-03-14 12:51 ` Eli Zaretskii
2011-03-14 12:52 ` Pierre Muller
2011-03-14 13:16 ` Eli Zaretskii
2011-03-14 12:59 ` Pedro Alves
2011-03-14 13:27 ` Eli Zaretskii
2011-03-14 13:46 ` Pedro Alves
2011-03-14 15:46 ` Pierre Muller
2011-03-19 21:15 ` Mark Kettenis
[not found] ` <18667.385276831$1300008680@news.gmane.org>
2011-03-14 15:54 ` [RFA] Fix ARI warning about function call in first column Tom Tromey
2011-03-14 16:46 ` [RFA-v2] " Pierre Muller
2011-03-14 17:02 ` Tom Tromey
[not found] ` <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr>
2011-03-14 17:17 ` Eli Zaretskii
2011-03-14 17:26 ` Pierre Muller
[not found] ` <10281.0550401502$1300122152@news.gmane.org>
2011-03-14 17:39 ` Tom Tromey
2011-03-15 12:19 ` [RFA] Fix formatting in " Pierre Muller
[not found] ` <45563.9187516228$1300186224@news.gmane.org>
2011-03-15 15:42 ` Tom Tromey
2011-03-15 16:01 ` Pierre Muller
[not found] ` <002001cbe269$85ed0e60$91c72b20$%muller@ics-cnrs.unistra.fr>
2011-03-14 21:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011501cbe161$5b67fcd0$1237f670$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox