From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19218 invoked by alias); 14 Mar 2011 13:16:29 -0000 Received: (qmail 19208 invoked by uid 22791); 14 Mar 2011 13:16:28 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 13:16:21 +0000 Received: (qmail 5056 invoked from network); 14 Mar 2011 13:16:19 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2011 13:16:19 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011 Date: Mon, 14 Mar 2011 13:46:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: pierre.muller@ics-cnrs.unistra.fr References: <20110312015329.GA20179@sourceware.org> <201103141251.31400.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103141316.17227.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00722.txt.bz2 On Monday 14 March 2011 13:06:08, Eli Zaretskii wrote: > > I'm fine with your suggestion, and in fact it's my preference > > as well. However, there are cases where you just can't do that, > > because the return type + function name + parameter end up being > > too long for a single line. > > What's wrong with leaving a single long line in such cases? They are > supposed to be very rare (if typedefs are used for complex function > arguments). If we have a rule to follow, we should follow it everywhere. And they are not very rare; we have quite a few cases. The most prominent styles are: /* Find a particular location expression from a location list. */ const gdb_byte *dwarf2_find_location_expression (struct dwarf2_loclist_baton *baton, size_t *locexpr_length, CORE_ADDR pc); /* Find an inferior bound to PSPACE. */ extern struct inferior * find_inferior_for_program_space (struct program_space *pspace); -- Pedro Alves