From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8855 invoked by alias); 14 Mar 2011 17:17:45 -0000 Received: (qmail 8829 invoked by uid 22791); 14 Mar 2011 17:17:43 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 17:17:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EHHW2G032258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Mar 2011 13:17:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2EHHWe2000517; Mon, 14 Mar 2011 13:17:32 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2EHHVXA019491; Mon, 14 Mar 2011 13:17:31 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 28A86378CA1; Mon, 14 Mar 2011 11:17:30 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: "'Eli Zaretskii'" , Subject: Re: [RFA-v2] Fix ARI warning about function call in first column References: <20110312015329.GA20179@sourceware.org> <010f01cbe157$aebb5cb0$0c321610$%muller@ics-cnrs.unistra.fr> <18667.385276831$1300008680@news.gmane.org> <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr> <83oc5dr6pj.fsf@gnu.org> <10281.0550401502$1300122152@news.gmane.org> Date: Mon, 14 Mar 2011 17:39:00 -0000 In-Reply-To: <10281.0550401502$1300122152@news.gmane.org> (Pierre Muller's message of "Mon, 14 Mar 2011 18:01:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00737.txt.bz2 Eli> I see no problem with long lines, if there are no better alternatives. I agree. Sometimes there really is no good answer and you just have to pick the least worst. Pierre> I hope everyone is OK with this. Pierre> I think that we do have lots of other occurrences Pierre> of lines longer than 80 cols anyhow... It is fine. Pierre> +static struct varobj * varobj_add_child (struct varobj *var, Pierre> + const char *name, Pierre> + struct value *value); Extra space after the "*". Pierre> +extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct Likewise. Pierre> +struct displaced_step_closure* get_displaced_step_closure_by_addr Space is on the wrong side of the "*"; I know you didn't cause this but if you are fixing the indentation anyway... Tom