From: Tom Tromey <tromey@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot
Date: Fri, 27 May 2011 17:47:00 -0000 [thread overview]
Message-ID: <m3boyovxws.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org> (Mike Frysinger's message of "Thu, 26 May 2011 16:03:20 -0400")
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> 2011-05-26 Mike Frysinger <vapier@gentoo.org>
Mike> * remote-sim.c (gdbsim_open): Add the strlen of " --sysroot=" and
Mike> gdb_sysroot to the "len" variable. Append both to "arg_buf".
It seems reasonable to me. Ok.
Mike> + strcat (arg_buf, gdb_sysroot);
It seems like this will give wrong results if the sysroot needs quoting.
But, this problem could affect other arguments here.
Offhand it seems like it would be better if this code directly built
sim_argv rather than building a string and converting it, but I don't
know if any odd issue is lurking.
Tom
next parent reply other threads:[~2011-05-27 17:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org>
2011-05-27 17:47 ` Tom Tromey [this message]
2011-05-27 18:37 ` Mike Frysinger
2011-06-01 16:18 ` [PATCH/RFC] new argv handlers to help with sim argv building Mike Frysinger
2011-06-03 16:56 ` Tom Tromey
2011-06-03 18:34 ` Mike Frysinger
2011-05-26 20:03 [PATCH] gdb: sim: automatically pass down sysroot Mike Frysinger
2011-05-26 20:10 ` Marek Polacek
2011-05-26 22:32 ` Mike Frysinger
2011-05-27 17:48 ` Tom Tromey
2011-05-27 17:54 ` Pedro Alves
2011-06-08 16:50 ` Joel Brobecker
2011-06-08 17:08 ` Mike Frysinger
2011-06-08 17:15 ` Joel Brobecker
2011-06-09 5:19 ` Mike Frysinger
2011-06-09 5:19 ` Mike Frysinger
2011-06-09 5:48 ` Joel Brobecker
2011-06-09 6:07 ` Mike Frysinger
2011-06-09 14:26 ` Joel Brobecker
2011-06-09 7:29 ` Tristan Gingold
2011-06-09 14:24 ` Joel Brobecker
2011-06-09 15:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3boyovxws.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox