Re: [PATCH/RFC] new argv handlers to help with sim argv building

[Tom Tromey <tromey@redhat.com>]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

Mike> i slapped this together.  what do you think (ignoring missing docs) ?

It seems reasonable to me overall, though see below.

Mike> +char **appendargv (char **argv, const char *arg, ...)

Wrong formatting.

The canonical source for libiberty is gcc, so changes have to go there.

Mike> +  argv = appendargv (argv, "--sysroot", gdb_sysroot, NULL);
[...]
Mike> +      uargv = gdb_buildargv (args);
Mike> +      sim_argv = mergeargv (argv, uargv, NULL);
Mike> +      freeargv (argv);

If there is only one argument potentially needing quoting from
buildargv, and we have to do splitting and merging as well, then it
seems like it would be simpler to just add a quoting function and use
that.

Tom