Re: [PATCH] gdb: sim: automatically pass down sysroot

[Joel Brobecker <brobecker@adacore.com>]

> here's the fix for erc32.  ok to commit ?

Yes, please. Thank you for taking care of that. Funny I didn't notice,
this problem, but it turns out that the error is non-fatal...

And good to know that this is the last simulator that should be
impacted.  If there is a relatively mechanichal way to use sim/common/,
we can look at that option, since the number of simulators to update
would be small (2?).

> (style is god awful, but seems the whole erc32 code base is buggered and i'm 
> not about to try and fix that)

I had the exact same reaction - it's just amazing how style differences
can make the reading so much more difficult.

> --- sim/erc32/interf.c	1 Jun 2011 17:35:02 -0000	1.10
> +++ sim/erc32/interf.c	9 Jun 2011 05:03:32 -0000
> @@ -234,6 +234,9 @@ sim_open (kind, callback, abfd, argv)
>  		if ((stat + 1) < argc) {
>  		    freq = strtol(argv[++stat], (char **)NULL, 0);
>  		}
> +	    } else
> +	    if (strncmp(argv[stat], "--sysroot=", sizeof("--sysroot=")) == 0) {
> +		/* Ignore until we start to support this.  */
>  	    } else {
>  		(*sim_callback->printf_filtered) (sim_callback,
>  						  "unknown option %s\n",

-- 
Joel