From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6681 invoked by alias); 9 Jun 2011 05:48:00 -0000 Received: (qmail 6669 invoked by uid 22791); 9 Jun 2011 05:48:00 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jun 2011 05:47:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3014C2BB4E4; Thu, 9 Jun 2011 01:47:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ku1T1Y23HRJ1; Thu, 9 Jun 2011 01:47:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EEDED2BB4CF; Thu, 9 Jun 2011 01:47:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 80805145615; Wed, 8 Jun 2011 22:47:42 -0700 (PDT) Date: Thu, 09 Jun 2011 05:48:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot Message-ID: <20110609054742.GE12834@adacore.com> References: <1306440200-25087-1-git-send-email-vapier@gentoo.org> <20110608164939.GA14178@adacore.com> <201106090107.44953.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201106090107.44953.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00121.txt.bz2 > here's the fix for erc32. ok to commit ? Yes, please. Thank you for taking care of that. Funny I didn't notice, this problem, but it turns out that the error is non-fatal... And good to know that this is the last simulator that should be impacted. If there is a relatively mechanichal way to use sim/common/, we can look at that option, since the number of simulators to update would be small (2?). > (style is god awful, but seems the whole erc32 code base is buggered and i'm > not about to try and fix that) I had the exact same reaction - it's just amazing how style differences can make the reading so much more difficult. > --- sim/erc32/interf.c 1 Jun 2011 17:35:02 -0000 1.10 > +++ sim/erc32/interf.c 9 Jun 2011 05:03:32 -0000 > @@ -234,6 +234,9 @@ sim_open (kind, callback, abfd, argv) > if ((stat + 1) < argc) { > freq = strtol(argv[++stat], (char **)NULL, 0); > } > + } else > + if (strncmp(argv[stat], "--sysroot=", sizeof("--sysroot=")) == 0) { > + /* Ignore until we start to support this. */ > } else { > (*sim_callback->printf_filtered) (sim_callback, > "unknown option %s\n", -- Joel