Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tristan Gingold <gingold@adacore.com>,
	toolchain-devel@blackfin.uclinux.org,
		gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot
Date: Thu, 09 Jun 2011 15:32:00 -0000	[thread overview]
Message-ID: <BANLkTi=gzW6ou6cp5_mguE6=gm2iZkCg0g@mail.gmail.com> (raw)
In-Reply-To: <20110609142421.GF12834@adacore.com>

On Thu, Jun 9, 2011 at 10:24, Joel Brobecker wrote:
>> > here's the fix for erc32.  ok to commit ?
>>
>> Is it correct ?  IIRC sizeof ("xxx") == strlen ("xxx") + 1.
>
> You're quite right.  The weird thing is that I had the "- 1"
> in my code at some point, I'm sure of that. How it came to
> disappear, I'm really puzzled.

i was working with constants originally, but when i looked at Joel's
patch, i copied & pasted what he did.  so the erc32 version i
committed includes his latest change.
-mike

--- interf.c    1 Jun 2011 17:35:02 -0000       1.10
+++ interf.c    9 Jun 2011 15:30:54 -0000
@@ -234,6 +234,9 @@ sim_open (kind, callback, abfd, argv)
                if ((stat + 1) < argc) {
                    freq = strtol(argv[++stat], (char **)NULL, 0);
                }
+           } else
+           if (strncmp(argv[stat], "--sysroot=", sizeof("--sysroot=")
- 1) == 0) {
+               /* Ignore until we start to support this.  */
            } else {
                (*sim_callback->printf_filtered) (sim_callback,
                                                  "unknown option %s\n",


  reply	other threads:[~2011-06-09 15:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 20:03 Mike Frysinger
2011-05-26 20:10 ` Marek Polacek
2011-05-26 22:32   ` Mike Frysinger
2011-05-27 17:48   ` Tom Tromey
2011-05-27 17:54     ` Pedro Alves
2011-06-08 16:50 ` Joel Brobecker
2011-06-08 17:08   ` Mike Frysinger
2011-06-08 17:15     ` Joel Brobecker
2011-06-09  5:19   ` Mike Frysinger
2011-06-09  5:19   ` Mike Frysinger
2011-06-09  5:48     ` Joel Brobecker
2011-06-09  6:07       ` Mike Frysinger
2011-06-09 14:26         ` Joel Brobecker
2011-06-09  7:29     ` Tristan Gingold
2011-06-09 14:24       ` Joel Brobecker
2011-06-09 15:32         ` Mike Frysinger [this message]
     [not found] <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org>
2011-05-27 17:47 ` Tom Tromey
2011-05-27 18:37   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=gzW6ou6cp5_mguE6=gm2iZkCg0g@mail.gmail.com' \
    --to=vapier@gentoo.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    --cc=toolchain-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox