From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22018 invoked by alias); 9 Jun 2011 15:32:53 -0000 Received: (qmail 22005 invoked by uid 22791); 9 Jun 2011 15:32:52 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jun 2011 15:32:37 +0000 Received: by fxm18 with SMTP id 18so1328339fxm.0 for ; Thu, 09 Jun 2011 08:32:36 -0700 (PDT) Received: by 10.223.73.133 with SMTP id q5mr959191faj.127.1307633556141; Thu, 09 Jun 2011 08:32:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.149.133 with HTTP; Thu, 9 Jun 2011 08:32:16 -0700 (PDT) In-Reply-To: <20110609142421.GF12834@adacore.com> References: <1306440200-25087-1-git-send-email-vapier@gentoo.org> <20110608164939.GA14178@adacore.com> <201106090107.44953.vapier@gentoo.org> <8BCAE08E-3F58-49B3-B822-E3BC2B298C7F@adacore.com> <20110609142421.GF12834@adacore.com> From: Mike Frysinger Date: Thu, 09 Jun 2011 15:32:00 -0000 Message-ID: Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot To: Joel Brobecker Cc: Tristan Gingold , toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00135.txt.bz2 On Thu, Jun 9, 2011 at 10:24, Joel Brobecker wrote: >> > here's the fix for erc32. =C2=A0ok to commit ? >> >> Is it correct ? =C2=A0IIRC sizeof ("xxx") =3D=3D strlen ("xxx") + 1. > > You're quite right. =C2=A0The weird thing is that I had the "- 1" > in my code at some point, I'm sure of that. How it came to > disappear, I'm really puzzled. i was working with constants originally, but when i looked at Joel's patch, i copied & pasted what he did. so the erc32 version i committed includes his latest change. -mike --- interf.c 1 Jun 2011 17:35:02 -0000 1.10 +++ interf.c 9 Jun 2011 15:30:54 -0000 @@ -234,6 +234,9 @@ sim_open (kind, callback, abfd, argv) if ((stat + 1) < argc) { freq =3D strtol(argv[++stat], (char **)NULL, 0); } + } else + if (strncmp(argv[stat], "--sysroot=3D", sizeof("--sysroot=3D") - 1) =3D=3D 0) { + /* Ignore until we start to support this. */ } else { (*sim_callback->printf_filtered) (sim_callback, "unknown option %s\n",