From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: brobecker@adacore.com (Joel Brobecker),
emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado),
mark.kettenis@xs4all.nl (Mark Kettenis),
gdb-patches@sourceware.org
Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs
Date: Tue, 03 Jan 2012 20:20:00 -0000 [thread overview]
Message-ID: <m3aa64fshr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201201031844.q03IiMwV001269@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Tue, 3 Jan 2012 19:44:22 +0100 (CET)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> I'm wondering whether this is best place to perform
Ulrich> this check, though -- maybe it might be better to label function
Ulrich> descriptor minsyms as mst_text to start with (or possibly some
Ulrich> new category) ...
Yeah, I wonder that too.
Ulrich> But in the absence of such a solution, I'd still be in favor of
Ulrich> committing your patch as is, given that it fixes a serious
Ulrich> regression and doesn't look like it can make things worse.
I agree.
Tom
next prev parent reply other threads:[~2012-01-03 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 10:17 Joel Brobecker
2011-12-23 11:03 ` Joel Brobecker
2011-12-23 14:53 ` Jan Kratochvil
2011-12-27 4:17 ` Joel Brobecker
2011-12-27 16:49 ` Edjunior Barbosa Machado
2011-12-27 17:09 ` Joel Brobecker
2011-12-27 19:58 ` Mark Kettenis
2011-12-28 7:07 ` Joel Brobecker
2011-12-28 13:02 ` Edjunior Barbosa Machado
2011-12-28 15:30 ` Joel Brobecker
2012-01-03 18:44 ` Ulrich Weigand
2012-01-03 20:20 ` Tom Tromey [this message]
2012-01-04 13:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa64fshr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox