From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29874 invoked by alias); 3 Jan 2012 20:20:52 -0000 Received: (qmail 29850 invoked by uid 22791); 3 Jan 2012 20:20:47 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Jan 2012 20:20:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q03KKJxn014116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Jan 2012 15:20:19 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q03KKI3c016528; Tue, 3 Jan 2012 15:20:18 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q03KKGaA020530; Tue, 3 Jan 2012 15:20:16 -0500 From: Tom Tromey To: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), mark.kettenis@xs4all.nl (Mark Kettenis), gdb-patches@sourceware.org Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs References: <20111228151541.GM23376@adacore.com> <201201031844.q03IiMwV001269@d06av02.portsmouth.uk.ibm.com> Date: Tue, 03 Jan 2012 20:20:00 -0000 In-Reply-To: <201201031844.q03IiMwV001269@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Tue, 3 Jan 2012 19:44:22 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00111.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> I'm wondering whether this is best place to perform Ulrich> this check, though -- maybe it might be better to label function Ulrich> descriptor minsyms as mst_text to start with (or possibly some Ulrich> new category) ... Yeah, I wonder that too. Ulrich> But in the absence of such a solution, I'd still be in favor of Ulrich> committing your patch as is, given that it fixes a serious Ulrich> regression and doesn't look like it can make things worse. I agree. Tom