Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs
Date: Wed, 28 Dec 2011 13:02:00 -0000	[thread overview]
Message-ID: <4EFB0EE2.9090806@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111228060200.GL23376@adacore.com>

On 12/28/2011 04:02 AM, Joel Brobecker wrote:

>> Give that the target in question is 64-bit PowerPC, my bet is that by
>> discarding data minimal symbols, you're also discarding function
>> descriptors.  That's probably not a good idea.
> 
> Thanks for the tip, Mark. After having looked at the logs, I think
> you are right on the money. What do you think of the attached patch?
> 
> Edjunior, can you test it for me?
> 
> Thanks,


Hi Joel,

excellent, I've tested it on ppc64 and it fixes all those regressions I mentioned.

Thanks a lot!
-- 
Edjunior


  reply	other threads:[~2011-12-28 12:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 10:17 Joel Brobecker
2011-12-23 11:03 ` Joel Brobecker
2011-12-23 14:53   ` Jan Kratochvil
2011-12-27  4:17 ` Joel Brobecker
2011-12-27 16:49   ` Edjunior Barbosa Machado
2011-12-27 17:09     ` Joel Brobecker
2011-12-27 19:58       ` Mark Kettenis
2011-12-28  7:07         ` Joel Brobecker
2011-12-28 13:02           ` Edjunior Barbosa Machado [this message]
2011-12-28 15:30             ` Joel Brobecker
2012-01-03 18:44               ` Ulrich Weigand
2012-01-03 20:20                 ` Tom Tromey
2012-01-04 13:38                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EFB0EE2.9090806@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox