From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs
Date: Tue, 27 Dec 2011 04:17:00 -0000 [thread overview]
Message-ID: <20111227041110.GA23376@adacore.com> (raw)
In-Reply-To: <1324548943-26819-1-git-send-email-brobecker@adacore.com>
> gdb/ChangeLog:
>
> * linespec.c (struct collect_minsyms) [list_mode]: New field.
> (add_minsym): Ignore data symbols if not in list mode.
> (search_minsyms_for_name): Set local.list_mode.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/dmsym.c, gdb.base/dmsym_main.c, gdb.base/dmsym.exp:
> New files.
I would normally wait to give the original author (Tom in this case)
some time to comment, but given that it fixes a couple of regressions
as well, and the fact that Jan is OK, I went ahead and checked it in.
If Tom has some comments, I don't mind fixing or reverting at all.
This is HEAD only. I think we'll want that for the branch, but I'll
wait for Tom's feedback, if any.
--
Joel
next prev parent reply other threads:[~2011-12-27 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 10:17 Joel Brobecker
2011-12-23 11:03 ` Joel Brobecker
2011-12-23 14:53 ` Jan Kratochvil
2011-12-27 4:17 ` Joel Brobecker [this message]
2011-12-27 16:49 ` Edjunior Barbosa Machado
2011-12-27 17:09 ` Joel Brobecker
2011-12-27 19:58 ` Mark Kettenis
2011-12-28 7:07 ` Joel Brobecker
2011-12-28 13:02 ` Edjunior Barbosa Machado
2011-12-28 15:30 ` Joel Brobecker
2012-01-03 18:44 ` Ulrich Weigand
2012-01-03 20:20 ` Tom Tromey
2012-01-04 13:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227041110.GA23376@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox