From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1585 invoked by alias); 27 Dec 2011 04:11:41 -0000 Received: (qmail 1287 invoked by uid 22791); 27 Dec 2011 04:11:40 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Dec 2011 04:11:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 162C42BAFAB; Mon, 26 Dec 2011 23:11:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DYkO0AHe8mdn; Mon, 26 Dec 2011 23:11:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 97A082BAF81; Mon, 26 Dec 2011 23:11:20 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 044B7145615; Mon, 26 Dec 2011 20:11:11 -0800 (PST) Date: Tue, 27 Dec 2011 04:17:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org, Tom Tromey Cc: Jan Kratochvil Subject: Re: [RFA] Ignore data minimal symbols for breakpoint linespecs Message-ID: <20111227041110.GA23376@adacore.com> References: <1324548943-26819-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324548943-26819-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00826.txt.bz2 > gdb/ChangeLog: > > * linespec.c (struct collect_minsyms) [list_mode]: New field. > (add_minsym): Ignore data symbols if not in list mode. > (search_minsyms_for_name): Set local.list_mode. > > gdb/testsuite/ChangeLog: > > * gdb.base/dmsym.c, gdb.base/dmsym_main.c, gdb.base/dmsym.exp: > New files. I would normally wait to give the original author (Tom in this case) some time to comment, but given that it fixes a couple of regressions as well, and the fact that Jan is OK, I went ahead and checked it in. If Tom has some comments, I don't mind fixing or reverting at all. This is HEAD only. I think we'll want that for the branch, but I'll wait for Tom's feedback, if any. -- Joel