From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Gary Benson <gbenson@redhat.com>
Subject: Re: [RFA] Improved linker-debugger interface
Date: Mon, 07 May 2012 17:51:00 -0000 [thread overview]
Message-ID: <m3aa1jq3r6.fsf@redhat.com> (raw)
In-Reply-To: <20120507165648.GA22472@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 7 May 2012 18:56:48 +0200")
On Monday, May 07 2012, Jan Kratochvil wrote:
> On Fri, 04 May 2012 17:21:29 +0200, Gary Benson wrote:
>> diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
>> index 69d3cb5..4897d51 100644
>> --- a/gdb/solib-svr4.c
>> +++ b/gdb/solib-svr4.c
>> @@ -47,6 +47,8 @@
>> #include "auxv.h"
>> #include "exceptions.h"
>>
>> +#include "stap-probe.h"
>
> Generic GDB code should only include "probe.h", not "stap-probe.h", so that
> the probes can be of arbitrary kind.
>
> It also no longer built with FSF GDB HEAD:
> solib-svr4.c: In function ‘svr4_update_solib_event_breakpoint’:
> solib-svr4.c:1463:33: error: dereferencing pointer to incomplete type
>
> but it gets fixed just by:
>
> -#include "stap-probe.h"
> +#include "probe.h"
FYI, this is because of:
http://sourceware.org/ml/gdb-cvs/2012-05/msg00035.html
Which I have committed just after reviewing Gary's patch.
--
Sergio
next prev parent reply other threads:[~2012-05-07 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 15:22 Gary Benson
2012-05-05 4:39 ` Sergio Durigan Junior
2012-05-05 6:03 ` Jan Kratochvil
2012-05-05 6:11 ` Sergio Durigan Junior
2012-05-05 6:23 ` Jan Kratochvil
2012-05-07 16:57 ` Jan Kratochvil
2012-05-07 17:51 ` Sergio Durigan Junior [this message]
2012-05-07 20:27 ` Tom Tromey
2012-05-07 21:32 ` Mark Kettenis
2012-05-07 21:44 ` Jan Kratochvil
2012-05-08 5:45 ` Sergio Durigan Junior
2012-05-08 13:37 ` Tom Tromey
2012-05-09 8:12 ` Mark Kettenis
2012-05-09 15:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa1jq3r6.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox