From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8005 invoked by alias); 7 May 2012 17:51:20 -0000 Received: (qmail 7945 invoked by uid 22791); 7 May 2012 17:51:19 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 May 2012 17:50:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q47Hox8D014190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 May 2012 13:50:59 -0400 Received: from psique ([10.3.112.12]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q47HosjP028048; Mon, 7 May 2012 13:50:56 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Gary Benson Subject: Re: [RFA] Improved linker-debugger interface References: <20120504152129.GA7418@redhat.com> <20120507165648.GA22472@host2.jankratochvil.net> X-URL: http://www.redhat.com Date: Mon, 07 May 2012 17:51:00 -0000 In-Reply-To: <20120507165648.GA22472@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 7 May 2012 18:56:48 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00183.txt.bz2 On Monday, May 07 2012, Jan Kratochvil wrote: > On Fri, 04 May 2012 17:21:29 +0200, Gary Benson wrote: >> diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c >> index 69d3cb5..4897d51 100644 >> --- a/gdb/solib-svr4.c >> +++ b/gdb/solib-svr4.c >> @@ -47,6 +47,8 @@ >> #include "auxv.h" >> #include "exceptions.h" >>=20=20 >> +#include "stap-probe.h" > > Generic GDB code should only include "probe.h", not "stap-probe.h", so th= at > the probes can be of arbitrary kind. > > It also no longer built with FSF GDB HEAD: > solib-svr4.c: In function =E2=80=98svr4_update_solib_event_breakpoint=E2= =80=99: > solib-svr4.c:1463:33: error: dereferencing pointer to incomplete type > > but it gets fixed just by: > > -#include "stap-probe.h" > +#include "probe.h" FYI, this is because of: http://sourceware.org/ml/gdb-cvs/2012-05/msg00035.html Which I have committed just after reviewing Gary's patch. --=20 Sergio