Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org, Gary Benson <gbenson@redhat.com>
Subject: Re: [RFA] Improved linker-debugger interface
Date: Sat, 05 May 2012 06:23:00 -0000	[thread overview]
Message-ID: <20120505062315.GA7458@host2.jankratochvil.net> (raw)
In-Reply-To: <m3vckbqhsg.fsf@redhat.com>

On Sat, 05 May 2012 08:10:55 +0200, Sergio Durigan Junior wrote:
> On Saturday, May 05 2012, Jan Kratochvil wrote:
> > There is that
> > 	gdb_assert (probe_generic->pops == &stap_probe_ops);
> >
> > for this purpose.
> 
> Which can only be used inside stap-probe.c.

Why?  stap_probe_ops can be made extern-public in stap-probe.h if there is now
a need for it.

But in general there should never be such backend-specific conditional, the
virtualization makes no sense in such case at all.

If the current probe.h interface is insufficient then it should be extended.

I have to look at the Gary's patch more.


Thanks,
Jan


  reply	other threads:[~2012-05-05  6:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 15:22 Gary Benson
2012-05-05  4:39 ` Sergio Durigan Junior
2012-05-05  6:03   ` Jan Kratochvil
2012-05-05  6:11     ` Sergio Durigan Junior
2012-05-05  6:23       ` Jan Kratochvil [this message]
2012-05-07 16:57 ` Jan Kratochvil
2012-05-07 17:51   ` Sergio Durigan Junior
2012-05-07 20:27   ` Tom Tromey
2012-05-07 21:32     ` Mark Kettenis
2012-05-07 21:44       ` Jan Kratochvil
2012-05-08  5:45       ` Sergio Durigan Junior
2012-05-08 13:37       ` Tom Tromey
2012-05-09  8:12         ` Mark Kettenis
2012-05-09 15:57           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120505062315.GA7458@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox