From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90710-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27351 invoked by alias); 5 May 2012 06:23:39 -0000
Received: (qmail 27339 invoked by uid 22791); 5 May 2012 06:23:38 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 May 2012 06:23:19 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q456NJCi016409	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Sat, 5 May 2012 02:23:19 -0400
Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q456NFdV014191	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Sat, 5 May 2012 02:23:18 -0400
Date: Sat, 05 May 2012 06:23:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org, Gary Benson <gbenson@redhat.com>
Subject: Re: [RFA] Improved linker-debugger interface
Message-ID: <20120505062315.GA7458@host2.jankratochvil.net>
References: <20120504152129.GA7418@redhat.com> <m37gwrs0m6.fsf@redhat.com> <20120505060312.GA7019@host2.jankratochvil.net> <m3vckbqhsg.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3vckbqhsg.fsf@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00152.txt.bz2

On Sat, 05 May 2012 08:10:55 +0200, Sergio Durigan Junior wrote:
> On Saturday, May 05 2012, Jan Kratochvil wrote:
> > There is that
> > 	gdb_assert (probe_generic->pops == &stap_probe_ops);
> >
> > for this purpose.
> 
> Which can only be used inside stap-probe.c.

Why?  stap_probe_ops can be made extern-public in stap-probe.h if there is now
a need for it.

But in general there should never be such backend-specific conditional, the
virtualization makes no sense in such case at all.

If the current probe.h interface is insufficient then it should be extended.

I have to look at the Gary's patch more.


Thanks,
Jan