From: Tom Tromey <tromey@redhat.com>
To: Samuel Bronson <naesten@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame".
Date: Thu, 04 Jun 2009 22:00:00 -0000 [thread overview]
Message-ID: <m37hzrwtgi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1243638987-4533-1-git-send-email-naesten@gmail.com> (Samuel Bronson's message of "Fri\, 29 May 2009 19\:16\:26 -0400")
>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
Samuel> Have "info frame" display this field when present.
Samuel> Fill in the field for unwinders (besides the sentinel) which are
Samuel> normally built on i386 Linux.
Funnily enough, I wanted this yesterday :)
This mostly looks ok. It needs a ChangeLog entry. And I have some
formatting nits...
Samuel> +const char *get_frame_unwinder_name (struct frame_info *frame)
Newline after the first "*".
Samuel> + unwinder = get_frame_unwinder_name(fi);
Space before the open paren.
Also, do you have copyright assignment papers in place? Those are a
prerequisite for us to accept a non-trivial patch.
Tom
next prev parent reply other threads:[~2009-06-04 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 23:09 Samuel Bronson
2009-05-29 23:10 ` [PATCH 2/2] Add "set/show debug unwinder" prefix commands Samuel Bronson
2009-05-30 6:57 ` Eli Zaretskii
2009-05-30 19:25 ` Doug Evans
2009-05-31 15:50 ` Samuel Bronson
2009-06-04 22:05 ` Tom Tromey
2009-06-09 0:49 ` Samuel Bronson
2009-06-09 19:44 ` Tom Tromey
2009-06-04 22:00 ` Tom Tromey [this message]
2009-06-09 0:24 ` [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame" Samuel Bronson
2009-06-09 19:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hzrwtgi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox