From: Tom Tromey <tromey@redhat.com>
To: Samuel Bronson <naesten@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame".
Date: Tue, 09 Jun 2009 19:41:00 -0000 [thread overview]
Message-ID: <m3r5xtjiuh.fsf@fleche.redhat.com> (raw)
In-Reply-To: <871vpudzkd.wl%naesten@gmail.com> (Samuel Bronson's message of "Mon\, 08 Jun 2009 20\:24\:18 -0400")
>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
Tom> This mostly looks ok. It needs a ChangeLog entry. And I have some
Tom> formatting nits...
Samuel> Hmm. How is that different from the thing above the patch (aka "commit
Samuel> message")?
There's an extensive, nit-picky standard for ChangeLog formatting.
http://www.gnu.org/prep/standards/standards.html#Change-Logs
A lot of the style manual is worth reading, just because we review
patches for conformance to it.
[ assignment ]
Samuel> Ah, no, not yet. I assume this doesn't qualify? I'd be fairly
Samuel> happy to do so, my concerns at this point being:
I will get you started. We can't answer your questions, but you can
ask the FSF assignment clerk and see what he says.
Tom
prev parent reply other threads:[~2009-06-09 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 23:09 Samuel Bronson
2009-05-29 23:10 ` [PATCH 2/2] Add "set/show debug unwinder" prefix commands Samuel Bronson
2009-05-30 6:57 ` Eli Zaretskii
2009-05-30 19:25 ` Doug Evans
2009-05-31 15:50 ` Samuel Bronson
2009-06-04 22:05 ` Tom Tromey
2009-06-09 0:49 ` Samuel Bronson
2009-06-09 19:44 ` Tom Tromey
2009-06-04 22:00 ` [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame" Tom Tromey
2009-06-09 0:24 ` Samuel Bronson
2009-06-09 19:41 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5xtjiuh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox