From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1278 invoked by alias); 4 Jun 2009 22:00:12 -0000 Received: (qmail 1259 invoked by uid 22791); 4 Jun 2009 22:00:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Jun 2009 22:00:03 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n54M00OK008942; Thu, 4 Jun 2009 18:00:00 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n54LxxYx017701; Thu, 4 Jun 2009 17:59:59 -0400 Received: from opsy.redhat.com (vpn-12-161.rdu.redhat.com [10.11.12.161]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n54LxwEM012305; Thu, 4 Jun 2009 17:59:58 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id E583A378615; Thu, 4 Jun 2009 15:59:57 -0600 (MDT) To: Samuel Bronson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Add an undwinder_name field to "struct frame_unwind" for use by "info frame". References: <1243638987-4533-1-git-send-email-naesten@gmail.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 04 Jun 2009 22:00:00 -0000 In-Reply-To: <1243638987-4533-1-git-send-email-naesten@gmail.com> (Samuel Bronson's message of "Fri\, 29 May 2009 19\:16\:26 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00085.txt.bz2 >>>>> "Samuel" == Samuel Bronson writes: Samuel> Have "info frame" display this field when present. Samuel> Fill in the field for unwinders (besides the sentinel) which are Samuel> normally built on i386 Linux. Funnily enough, I wanted this yesterday :) This mostly looks ok. It needs a ChangeLog entry. And I have some formatting nits... Samuel> +const char *get_frame_unwinder_name (struct frame_info *frame) Newline after the first "*". Samuel> + unwinder = get_frame_unwinder_name(fi); Space before the open paren. Also, do you have copyright assignment papers in place? Those are a prerequisite for us to accept a non-trivial patch. Tom