Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [patch] [python] Implement Inferior.current_inferior
Date: Tue, 28 Jun 2011 08:20:00 -0000	[thread overview]
Message-ID: <m37h86tlk7.fsf@redhat.com> (raw)
In-Reply-To: <BANLkTikeKLWp9mbyWJki0t4mqxDANdNmPg@mail.gmail.com> (Kevin	Pouget's message of "Tue, 28 Jun 2011 09:46:42 +0200")

Kevin Pouget <kevin.pouget@gmail.com> writes:

> Hi,
>
> sorry for the troubles, I'll assign the patches to myself next times!

That's ok, like I mentioned I did not do it for this bug either!  But
assignments do avoid issues like these.  As it happens I spent most of
the time with the patch fixing the reference counting buglets.  So go
ahead and assign yourself whatever bugs you are working on now.  When
you get your FSF paperwork sorted generally, and maintainer approval for
each patch, make sure you put the bug number in the ChangeLog (look for
other examples of this), and close the bug with the target milestone set
for the expected release of this patch (e.g. 7.4).

> the patch was reviewed and accepted,

Ok, then lets do this.  You wrote the patch, it was reviewed and
accepted so your patch should go in. This functionality is targeted
for 7.4 and so that is quite a long time away. You will (hopefully) have
FSF assignment sorted by then!  I'll break out the reference counting
fixes and submit it as a separate patch.  This is important as
selected_inferior will crash on short lived anonymous references.  The
two patches should come together nicely, then.


Does this sound okay to you?

Thanks again for all your work, Kevin.

Cheers,

Phil


  reply	other threads:[~2011-06-28  8:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 14:11 Phil Muldoon
2011-06-27 17:35 ` Kevin Pouget
2011-06-27 19:30   ` Phil Muldoon
2011-06-27 20:13     ` Joel Brobecker
2011-06-27 20:27       ` Phil Muldoon
2011-06-28  7:47         ` Kevin Pouget
2011-06-28  8:20           ` Phil Muldoon [this message]
2011-06-28 20:31   ` Tom Tromey
2011-06-28 20:30 ` Tom Tromey
2011-06-28 22:14   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37h86tlk7.fsf@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevin.pouget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox