From: Phil Muldoon <pmuldoon@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Kevin Pouget <kevin.pouget@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [patch] [python] Implement Inferior.current_inferior
Date: Mon, 27 Jun 2011 20:27:00 -0000 [thread overview]
Message-ID: <m3k4c781hf.fsf@redhat.com> (raw)
In-Reply-To: <20110627201314.GK20676@adacore.com> (Joel Brobecker's message of "Mon, 27 Jun 2011 13:13:14 -0700")
Joel Brobecker <brobecker@adacore.com> writes:
>> Whether your patch, or mine makes it in I don't mind. The patches looks
>> similar, but mine has a few extra tests and accounts for the reference
>> leaking/sigsegv. I would be happy to add your name to the ChangeLog as
>> co-implementer if the maintainers think this is ok (and they approve the
>> patch).
>
> It could be a merge of the two patches, with both names on the CL,
> I think.
As our patches are basically the same, the merge would not really be
needed. Apart from the reference counting hunks, they are basically the
same. I would take my patch which deals with the reference counting
issue and add Kevin's name to the ChangeLog. (At least to me that is the
cleanest way to do it other than trying to merge two very similar
patches.)
My real question was: As Kevin is lost in FSF paperwork with substantial
delays, if it would be okay under the current FSF assignment rules to
co-credit the ChangeLog with Kevin as the author. It probably isn't - I
know some projects do this, but I have no experience with this scenario
in GDB. As Kevin has a previous implementation that is pending FSF
paperwork (I am not sure if his patch was reviewed), I think he should
have the first shot/discussion on that patch. I guess we have to just
wait?
Cheers,
Phil
next prev parent reply other threads:[~2011-06-27 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 14:11 Phil Muldoon
2011-06-27 17:35 ` Kevin Pouget
2011-06-27 19:30 ` Phil Muldoon
2011-06-27 20:13 ` Joel Brobecker
2011-06-27 20:27 ` Phil Muldoon [this message]
2011-06-28 7:47 ` Kevin Pouget
2011-06-28 8:20 ` Phil Muldoon
2011-06-28 20:31 ` Tom Tromey
2011-06-28 20:30 ` Tom Tromey
2011-06-28 22:14 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4c781hf.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox