Re: [patch] [python] Implement Inferior.current_inferior

[Tom Tromey <tromey@redhat.com>]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> -/* Return a borrowed reference to the Python object of type Inferior
Phil> +/* Return a reference to the Python object of type Inferior
Phil>     representing INFERIOR.  If the object has already been created,
Phil> -   return it,  otherwise, create it.  Return NULL on failure.  */
Phil> +   return it and increment the reference count,  otherwise, create it.
Phil> +   Return NULL on failure.  */
Phil>  PyObject *
Phil>  inferior_to_inferior_object (struct inferior *inferior)
Phil>  {
Phil> @@ -154,13 +155,14 @@ inferior_to_inferior_object (struct inferior *inferior)
 
Phil>        do_cleanups (cleanup);
Phil>      }
Phil> +  else
Phil> +    Py_INCREF ((PyObject *)inf_obj);

I don't really follow this.

I think the best model would be that the 'struct inferior' owns a
reference to the gdb.Inferior object, and then
inferior_to_inferior_object is consistent: it either always returns a
new reference or a borrowed reference.

For a borrowed reference, I think you can leave this function as-is.

For a new reference, I think you need to remove the 'else' from your
patch, and update infpy_dealloc to decref.

Tom