From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29184 invoked by alias); 28 Jun 2011 08:20:30 -0000 Received: (qmail 29174 invoked by uid 22791); 28 Jun 2011 08:20:28 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 08:20:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5S8JcoF028059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Jun 2011 04:19:38 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5S8JauU012608; Tue, 28 Jun 2011 04:19:37 -0400 From: Phil Muldoon To: Kevin Pouget Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch] [python] Implement Inferior.current_inferior References: <20110627201314.GK20676@adacore.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Tue, 28 Jun 2011 08:20:00 -0000 In-Reply-To: (Kevin Pouget's message of "Tue, 28 Jun 2011 09:46:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00413.txt.bz2 Kevin Pouget writes: > Hi, > > sorry for the troubles, I'll assign the patches to myself next times! That's ok, like I mentioned I did not do it for this bug either! But assignments do avoid issues like these. As it happens I spent most of the time with the patch fixing the reference counting buglets. So go ahead and assign yourself whatever bugs you are working on now. When you get your FSF paperwork sorted generally, and maintainer approval for each patch, make sure you put the bug number in the ChangeLog (look for other examples of this), and close the bug with the target milestone set for the expected release of this patch (e.g. 7.4). > the patch was reviewed and accepted, Ok, then lets do this. You wrote the patch, it was reviewed and accepted so your patch should go in. This functionality is targeted for 7.4 and so that is quite a long time away. You will (hopefully) have FSF assignment sorted by then! I'll break out the reference counting fixes and submit it as a separate patch. This is important as selected_inferior will crash on short lived anonymous references. The two patches should come together nicely, then. Does this sound okay to you? Thanks again for all your work, Kevin. Cheers, Phil