From: Tom Tromey <tromey@redhat.com>
To: John Steele Scott <toojays@toojays.net>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries.
Date: Tue, 15 Nov 2011 17:19:00 -0000 [thread overview]
Message-ID: <m37h31mhhi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4EBFB451.8030503@toojays.net> (John Steele Scott's message of "Sun, 13 Nov 2011 22:43:05 +1030")
>>>>> "John" == John Steele Scott <toojays@toojays.net> writes:
Jan> There is one problem that -gdwarf-4 (-fdebug-types-section)
Jan> .debug_types units do not contain DW_AT_producer and GDB currently
Jan> does not try to inherit it from the referencing .debug_info
Jan> sections.
Jan> But latest icc still does not support DW_AT_producer and I am not
Jan> sure if it would use the declaration form inside .debug_types
Jan> anyway.
John> I don't follow this paragraph. Did you mean something other than
John> icc? I'm using ICC 12.0.4, and it's definitely setting
John> DW_AT_producer. I don't see it outputting any .debug_types section
John> though, it seems to only emit dwarf2.
I think maybe he meant .debug_types in that second paragraph where he
wrote DW_AT_producer. Or maybe I just don't understand as well :)
John> 2011-11-13 John Steele Scott <toojays@toojays.net>
John> PR symtab/13277: Resolving opaque structures in ICC generated binaries.
John> * dwarf2read.c (producer_is_icc): New function.
John> (read_structure_type): Set TYPE_STUB on structures/unions/classes
John> with a byte size of zero, if they were produced by ICC.
John> (process_structure_scope): Extract "external reference" check into
John> die_is_incomplete_type.
John> (die_is_incomplete_type): New function.
John> (read_partial_die): If a structure/union/class has a byte_size of zero,
John> and it was produced by ICC, set part_die->is_declaration instead of
This patch is ok. You didn't say, but I assume it passed all regression
tests?
Tom
next prev parent reply other threads:[~2011-11-15 17:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 8:03 John Steele Scott
2011-10-19 9:01 ` Jan Kratochvil
2011-10-19 13:54 ` Jan Kratochvil
2011-10-23 18:29 ` John Steele Scott
2011-10-24 0:13 ` Joel Brobecker
2011-10-27 19:57 ` Tom Tromey
2011-10-23 10:26 ` John Steele Scott
2011-10-26 23:09 ` Jan Kratochvil
2011-11-13 11:38 ` [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase) John Steele Scott
2011-11-15 17:04 ` Tom Tromey
2012-05-05 2:40 ` John Steele Scott
2012-05-05 15:16 ` Joel Brobecker
2012-05-05 15:36 ` Jan Kratochvil
2012-05-12 9:00 ` John Steele Scott
2012-05-12 18:38 ` Jan Kratochvil
2012-05-12 19:09 ` Joel Brobecker
2012-05-21 12:05 ` John Steele Scott
2012-05-21 12:08 ` John Steele Scott
2012-05-24 23:06 ` [commit] " Jan Kratochvil
2012-05-21 12:17 ` Jan Kratochvil
2011-11-13 12:13 ` [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries John Steele Scott
2011-11-15 17:19 ` Tom Tromey [this message]
2011-11-15 23:58 ` Jan Kratochvil
2012-05-05 2:32 ` John Steele Scott
2012-05-12 18:37 ` Jan Kratochvil
2012-05-14 13:55 ` John Steele Scott
[not found] ` <20120518144642.GA19690@host2.jankratochvil.net>
2012-05-20 12:34 ` John Steele Scott
[not found] ` <20120520130919.GA6990@host2.jankratochvil.net>
2012-05-20 13:17 ` Jan Kratochvil
2012-05-20 13:44 ` John Steele Scott
2012-05-23 23:29 ` John Steele Scott
2012-05-24 15:16 ` Pedro Alves
2012-05-24 22:13 ` [commit] " Jan Kratochvil
2012-05-24 23:05 ` John Steele Scott
2012-05-24 22:16 ` [commit TYPE_OPAQUE] " Jan Kratochvil
2012-05-21 0:12 ` Doug Evans
2012-05-20 13:17 ` Jan Kratochvil
-- strict thread matches above, loose matches on Subject: below --
2011-10-16 7:58 John Steele Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37h31mhhi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=toojays@toojays.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox