From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21375 invoked by alias); 15 Nov 2011 17:19:28 -0000 Received: (qmail 21357 invoked by uid 22791); 15 Nov 2011 17:19:27 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_GD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 17:18:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAFHIpvp026742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Nov 2011 12:18:51 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAFHIp1G000347; Tue, 15 Nov 2011 12:18:51 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAFHInTv006396; Tue, 15 Nov 2011 12:18:50 -0500 From: Tom Tromey To: John Steele Scott Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFB451.8030503@toojays.net> Date: Tue, 15 Nov 2011 17:19:00 -0000 In-Reply-To: <4EBFB451.8030503@toojays.net> (John Steele Scott's message of "Sun, 13 Nov 2011 22:43:05 +1030") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00394.txt.bz2 >>>>> "John" == John Steele Scott writes: Jan> There is one problem that -gdwarf-4 (-fdebug-types-section) Jan> .debug_types units do not contain DW_AT_producer and GDB currently Jan> does not try to inherit it from the referencing .debug_info Jan> sections. Jan> But latest icc still does not support DW_AT_producer and I am not Jan> sure if it would use the declaration form inside .debug_types Jan> anyway. John> I don't follow this paragraph. Did you mean something other than John> icc? I'm using ICC 12.0.4, and it's definitely setting John> DW_AT_producer. I don't see it outputting any .debug_types section John> though, it seems to only emit dwarf2. I think maybe he meant .debug_types in that second paragraph where he wrote DW_AT_producer. Or maybe I just don't understand as well :) John> 2011-11-13 John Steele Scott John> PR symtab/13277: Resolving opaque structures in ICC generated binaries. John> * dwarf2read.c (producer_is_icc): New function. John> (read_structure_type): Set TYPE_STUB on structures/unions/classes John> with a byte size of zero, if they were produced by ICC. John> (process_structure_scope): Extract "external reference" check into John> die_is_incomplete_type. John> (die_is_incomplete_type): New function. John> (read_partial_die): If a structure/union/class has a byte_size of zero, John> and it was produced by ICC, set part_die->is_declaration instead of This patch is ok. You didn't say, but I assume it passed all regression tests? Tom