From: Pedro Alves <palves@redhat.com>
To: John Steele Scott <toojays@toojays.net>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
Tom Tromey <tromey@redhat.com>,
gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries.
Date: Thu, 24 May 2012 15:16:00 -0000 [thread overview]
Message-ID: <4FBE50A6.6000106@redhat.com> (raw)
In-Reply-To: <87ipfmxyro.fsf@quantum.com>
On 05/24/2012 12:28 AM, John Steele Scott wrote:
> - /* These cache the results of producer_is_gxx_lt_4_6.
> - CHECKED_PRODUCER is set if PRODUCER_IS_GXX_LT_4_6 is valid. This
> - information is cached because profiling CU expansion showed
> - excessive time spent in producer_is_gxx_lt_4_6. */
> + /* These cache the results for producer_is_gxx_lt_4_6 and producer_is_icc.
> + CHECKED_PRODUCER is set if both PRODUCER_IS_GXX_LT_4_6 and PRODUCER_IS_ICC
> + are valid. This information is cached because profiling CU expansion
> + showed excessive time spent in producer_is_gxx_lt_4_6. */
> unsigned int checked_producer : 1;
> unsigned int producer_is_gxx_lt_4_6 : 1;
> + unsigned int producer_is_icc : 1;
Doesn't matter much at this point, since you'd need two bits anyway,
but I'll note that producer_is_gxx_lt_4_6 and producer_is_icc are mutually
exclusive, so an enum (ENUM_BITFIELD) would be a better match.
--
Pedro Alves
next prev parent reply other threads:[~2012-05-24 15:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 8:03 John Steele Scott
2011-10-19 9:01 ` Jan Kratochvil
2011-10-19 13:54 ` Jan Kratochvil
2011-10-23 18:29 ` John Steele Scott
2011-10-24 0:13 ` Joel Brobecker
2011-10-27 19:57 ` Tom Tromey
2011-10-23 10:26 ` John Steele Scott
2011-10-26 23:09 ` Jan Kratochvil
2011-11-13 11:38 ` [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase) John Steele Scott
2011-11-15 17:04 ` Tom Tromey
2012-05-05 2:40 ` John Steele Scott
2012-05-05 15:16 ` Joel Brobecker
2012-05-05 15:36 ` Jan Kratochvil
2012-05-12 9:00 ` John Steele Scott
2012-05-12 18:38 ` Jan Kratochvil
2012-05-12 19:09 ` Joel Brobecker
2012-05-21 12:05 ` John Steele Scott
2012-05-21 12:08 ` John Steele Scott
2012-05-24 23:06 ` [commit] " Jan Kratochvil
2012-05-21 12:17 ` Jan Kratochvil
2011-11-13 12:13 ` [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries John Steele Scott
2011-11-15 17:19 ` Tom Tromey
2011-11-15 23:58 ` Jan Kratochvil
2012-05-05 2:32 ` John Steele Scott
2012-05-12 18:37 ` Jan Kratochvil
2012-05-14 13:55 ` John Steele Scott
[not found] ` <20120518144642.GA19690@host2.jankratochvil.net>
2012-05-20 12:34 ` John Steele Scott
[not found] ` <20120520130919.GA6990@host2.jankratochvil.net>
2012-05-20 13:17 ` Jan Kratochvil
2012-05-20 13:44 ` John Steele Scott
2012-05-23 23:29 ` John Steele Scott
2012-05-24 15:16 ` Pedro Alves [this message]
2012-05-24 22:13 ` [commit] " Jan Kratochvil
2012-05-24 23:05 ` John Steele Scott
2012-05-24 22:16 ` [commit TYPE_OPAQUE] " Jan Kratochvil
2012-05-21 0:12 ` Doug Evans
2012-05-20 13:17 ` Jan Kratochvil
-- strict thread matches above, loose matches on Subject: below --
2011-10-16 7:58 John Steele Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE50A6.6000106@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=toojays@toojays.net \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox