From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16089 invoked by alias); 24 May 2012 15:16:31 -0000 Received: (qmail 16075 invoked by uid 22791); 24 May 2012 15:16:30 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 May 2012 15:16:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4OFFq8b015906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 May 2012 11:15:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4OFFoJx028205; Thu, 24 May 2012 11:15:51 -0400 Message-ID: <4FBE50A6.6000106@redhat.com> Date: Thu, 24 May 2012 15:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: John Steele Scott CC: Jan Kratochvil , Tom Tromey , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. References: <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFB451.8030503@toojays.net> <4FA4912E.9050709@toojays.net> <20120512183722.GA20606@host2.jankratochvil.net> <4FB10DD8.7040501@toojays.net> <20120518144642.GA19690@host2.jankratochvil.net> <4FB8E4BD.6000501@toojays.net> <20120520130919.GA6990@host2.jankratochvil.net> <20120520131719.GB7416@host2.jankratochvil.net> <87ipfmxyro.fsf@quantum.com> In-Reply-To: <87ipfmxyro.fsf@quantum.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00928.txt.bz2 On 05/24/2012 12:28 AM, John Steele Scott wrote: > - /* These cache the results of producer_is_gxx_lt_4_6. > - CHECKED_PRODUCER is set if PRODUCER_IS_GXX_LT_4_6 is valid. This > - information is cached because profiling CU expansion showed > - excessive time spent in producer_is_gxx_lt_4_6. */ > + /* These cache the results for producer_is_gxx_lt_4_6 and producer_is_icc. > + CHECKED_PRODUCER is set if both PRODUCER_IS_GXX_LT_4_6 and PRODUCER_IS_ICC > + are valid. This information is cached because profiling CU expansion > + showed excessive time spent in producer_is_gxx_lt_4_6. */ > unsigned int checked_producer : 1; > unsigned int producer_is_gxx_lt_4_6 : 1; > + unsigned int producer_is_icc : 1; Doesn't matter much at this point, since you'd need two bits anyway, but I'll note that producer_is_gxx_lt_4_6 and producer_is_icc are mutually exclusive, so an enum (ENUM_BITFIELD) would be a better match. -- Pedro Alves