Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase)

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Sat, 12 May 2012 11:00:22 +0200, John Steele Scott wrote:
> --- /dev/null
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
> @@ -0,0 +1,192 @@
> +/* Copyright (C) 2011-2012 Free Software Foundation, Inc.

Only 2012 as AFAIK the copyright applies only for the time it is checked in
FSF repository.


[...]
> +	.file "opaque-pointer.c"
[...]
> +	.file "opaque-struct.c"

Please include these two files as a comment into this .S file, for later
investigation what was the real source code etc.


Also please make this change:

@@ -226,7 +226,7 @@ index 0000000..4fc6512
-+	.byte 0x08			/* Target address size. */
++	.byte 0x04			/* Target address size. */
@@ -239,8 +239,8 @@ index 0000000..4fc6512
-+	.2byte 0x0309			/* DW_AT_location: 9 bytes, DW_OP_addr */
-+	.8byte p_struct			/* followed by the address of p_struct. */
++	.2byte 0x0305			/* DW_AT_location: 5 bytes, DW_OP_addr */
++	.4byte p_struct			/* followed by the address of p_struct. */
@@ -313,7 +313,7 @@ index 0000000..4fc6512
-+	.byte 0x08			/* Target address size. */
++	.byte 0x04			/* Target address size. */

It will make the testcase 32-bit, therefore compatible with both 64-bit and
32-bit targets.  Otherwise it gave:
	gdb compile failed, opaque-pointer.c: Assembler messages:
	opaque-pointer.c:42: Error: cannot represent relocation type BFD_RELOC_64


> --- /dev/null
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp
> @@ -0,0 +1,37 @@
> +# Copyright (C) 2011-2012 Free Software Foundation, Inc.

Only 2012 again.

I will check it in after the update.


Thanks,
Jan