From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26514 invoked by alias); 12 May 2012 18:38:13 -0000 Received: (qmail 26390 invoked by uid 22791); 12 May 2012 18:38:12 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 May 2012 18:38:00 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4CIbl51002397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 12 May 2012 14:37:47 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4CIbfV5018131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 12 May 2012 14:37:44 -0400 Date: Sat, 12 May 2012 18:38:00 -0000 From: Jan Kratochvil To: John Steele Scott Cc: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase) Message-ID: <20120512183741.GB20606@host2.jankratochvil.net> References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFAC05.2070501@toojays.net> <4FA49314.5020508@toojays.net> <20120505151557.GU15555@adacore.com> <87wr4h4vvd.fsf@quantum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wr4h4vvd.fsf@quantum.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00481.txt.bz2 On Sat, 12 May 2012 11:00:22 +0200, John Steele Scott wrote: > --- /dev/null > +++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S > @@ -0,0 +1,192 @@ > +/* Copyright (C) 2011-2012 Free Software Foundation, Inc. Only 2012 as AFAIK the copyright applies only for the time it is checked in FSF repository. [...] > + .file "opaque-pointer.c" [...] > + .file "opaque-struct.c" Please include these two files as a comment into this .S file, for later investigation what was the real source code etc. Also please make this change: @@ -226,7 +226,7 @@ index 0000000..4fc6512 -+ .byte 0x08 /* Target address size. */ ++ .byte 0x04 /* Target address size. */ @@ -239,8 +239,8 @@ index 0000000..4fc6512 -+ .2byte 0x0309 /* DW_AT_location: 9 bytes, DW_OP_addr */ -+ .8byte p_struct /* followed by the address of p_struct. */ ++ .2byte 0x0305 /* DW_AT_location: 5 bytes, DW_OP_addr */ ++ .4byte p_struct /* followed by the address of p_struct. */ @@ -313,7 +313,7 @@ index 0000000..4fc6512 -+ .byte 0x08 /* Target address size. */ ++ .byte 0x04 /* Target address size. */ It will make the testcase 32-bit, therefore compatible with both 64-bit and 32-bit targets. Otherwise it gave: gdb compile failed, opaque-pointer.c: Assembler messages: opaque-pointer.c:42: Error: cannot represent relocation type BFD_RELOC_64 > --- /dev/null > +++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp > @@ -0,0 +1,37 @@ > +# Copyright (C) 2011-2012 Free Software Foundation, Inc. Only 2012 again. I will check it in after the update. Thanks, Jan