Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: bogus main declaration in gdb.base/label.c
Date: Tue, 15 Jan 2013 18:18:00 -0000	[thread overview]
Message-ID: <m37gne2ttu.fsf@redhat.com> (raw)
In-Reply-To: <CAENS6EvD1aJSsLXuJKPT2322LYCk6C01DiuXPXvP0U88HAGH9w@mail.gmail.com>

On Tuesday, January 15 2013, David Blaikie wrote:

> Still a little fuzzy on ChangeLog entries, especially for patches
> (following the contribution documentation it ends up pointing at
> threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html (
> from http://gcc.gnu.org/codingconventions.html#ChangeLogs ))
>
>     * testsuite/gdb.base/label.c: Correct the type of the second
> parameter to main.

Hi David,

Thanks for your contribution.  The ChangeLog needs to be written
according to the GNU Coding Standards (as you have noticed).  The best
way to learn how to write an entry for them is to take a look at the
existing ChangeLogs: gdb/ChangeLog is a good source of information :-).
In your specific case, there is a ChangeLog file in gdb/testsuite, so
you don't need to include the prefix `testsuite/' in your entry.

Anyway, you would write your entry as:

2013-01-15  David Blaikie  <dblaikie@gmail.com>

	* gdb.base/label.c (main): Correct the type of the second
	parameter.

Or something like that.

Thanks,

-- 
Sergio


  reply	other threads:[~2013-01-15 18:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 20:52 David Blaikie
2013-01-14 21:29 ` Tom Tromey
2013-01-15 18:07   ` David Blaikie
2013-01-15 18:18     ` Sergio Durigan Junior [this message]
2013-01-15 18:33       ` David Blaikie
2013-01-17 17:29         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37gne2ttu.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox