From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5173 invoked by alias); 15 Jan 2013 18:18:49 -0000 Received: (qmail 5157 invoked by uid 22791); 15 Jan 2013 18:18:47 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 18:18:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0FIIfv2025431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Jan 2013 13:18:41 -0500 Received: from psique (ovpn-113-154.phx2.redhat.com [10.3.113.154]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0FIIc5d029485; Tue, 15 Jan 2013 13:18:39 -0500 From: Sergio Durigan Junior To: David Blaikie Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: bogus main declaration in gdb.base/label.c References: <87k3rfmp2l.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Tue, 15 Jan 2013 18:18:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00317.txt.bz2 On Tuesday, January 15 2013, David Blaikie wrote: > Still a little fuzzy on ChangeLog entries, especially for patches > (following the contribution documentation it ends up pointing at > threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html ( > from http://gcc.gnu.org/codingconventions.html#ChangeLogs )) > > * testsuite/gdb.base/label.c: Correct the type of the second > parameter to main. Hi David, Thanks for your contribution. The ChangeLog needs to be written according to the GNU Coding Standards (as you have noticed). The best way to learn how to write an entry for them is to take a look at the existing ChangeLogs: gdb/ChangeLog is a good source of information :-). In your specific case, there is a ChangeLog file in gdb/testsuite, so you don't need to include the prefix `testsuite/' in your entry. Anyway, you would write your entry as: 2013-01-15 David Blaikie * gdb.base/label.c (main): Correct the type of the second parameter. Or something like that. Thanks, -- Sergio