Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Blaikie <dblaikie@gmail.com>
To: gdb-patches@sourceware.org
Subject: bogus main declaration in gdb.base/label.c
Date: Mon, 14 Jan 2013 20:52:00 -0000	[thread overview]
Message-ID: <CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

The declaration of main in gdb.base/label.c is incorrect & fails to
compile under Clang:

../../../src/gdb/7.5/gdb/testsuite/gdb.base/label.c:4:1: error: second
parameter of 'main' (argument array) must be of type 'char **'
main (int argc, char *argv)
^

The attached patch fixes this by adding the missing '*' to the second parameter.

[-- Attachment #2: gdb-label.diff --]
[-- Type: application/octet-stream, Size: 307 bytes --]

diff --git gdb/testsuite/gdb.base/label.c gdb/testsuite/gdb.base/label.c
index f9cd8c3..c15e3bf 100644
--- gdb/testsuite/gdb.base/label.c
+++ gdb/testsuite/gdb.base/label.c
@@ -1,7 +1,7 @@
 #include <stdio.h>
 
 int
-main (int argc, char *argv)
+main (int argc, char **argv)
 {
   int i = 0;
   goto there;

             reply	other threads:[~2013-01-14 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 20:52 David Blaikie [this message]
2013-01-14 21:29 ` Tom Tromey
2013-01-15 18:07   ` David Blaikie
2013-01-15 18:18     ` Sergio Durigan Junior
2013-01-15 18:33       ` David Blaikie
2013-01-17 17:29         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com' \
    --to=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox