From: Tom Tromey <tromey@redhat.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: bogus main declaration in gdb.base/label.c
Date: Mon, 14 Jan 2013 21:29:00 -0000 [thread overview]
Message-ID: <87k3rfmp2l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com> (David Blaikie's message of "Mon, 14 Jan 2013 12:52:02 -0800")
>>>>> "David" == David Blaikie <dblaikie@gmail.com> writes:
David> The declaration of main in gdb.base/label.c is incorrect & fails to
David> compile under Clang:
David> ../../../src/gdb/7.5/gdb/testsuite/gdb.base/label.c:4:1: error: second
David> parameter of 'main' (argument array) must be of type 'char **'
David> main (int argc, char *argv)
David> ^
David> The attached patch fixes this by adding the missing '*' to the
David> second parameter.
It needs a ChangeLog entry, but otherwise is ok.
If you're going to submit more patches, you should start the copyright
assignment process. Send me email off-list & I will send you what you
need.
Tom
next prev parent reply other threads:[~2013-01-14 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 20:52 David Blaikie
2013-01-14 21:29 ` Tom Tromey [this message]
2013-01-15 18:07 ` David Blaikie
2013-01-15 18:18 ` Sergio Durigan Junior
2013-01-15 18:33 ` David Blaikie
2013-01-17 17:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3rfmp2l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dblaikie@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox