From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97665-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19774 invoked by alias); 14 Jan 2013 21:29:06 -0000
Received: (qmail 19760 invoked by uid 22791); 14 Jan 2013 21:29:05 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 21:28:52 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0ELSpqC013826	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 14 Jan 2013 16:28:51 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0ELSoGh000750	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 14 Jan 2013 16:28:50 -0500
From: Tom Tromey <tromey@redhat.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: bogus main declaration in gdb.base/label.c
References: <CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com>
Date: Mon, 14 Jan 2013 21:29:00 -0000
In-Reply-To: <CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com>	(David Blaikie's message of "Mon, 14 Jan 2013 12:52:02 -0800")
Message-ID: <87k3rfmp2l.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00295.txt.bz2

>>>>> "David" == David Blaikie <dblaikie@gmail.com> writes:

David> The declaration of main in gdb.base/label.c is incorrect & fails to
David> compile under Clang:

David> ../../../src/gdb/7.5/gdb/testsuite/gdb.base/label.c:4:1: error: second
David> parameter of 'main' (argument array) must be of type 'char **'
David> main (int argc, char *argv)
David> ^

David> The attached patch fixes this by adding the missing '*' to the
David> second parameter.

It needs a ChangeLog entry, but otherwise is ok.

If you're going to submit more patches, you should start the copyright
assignment process.  Send me email off-list & I will send you what you
need.

Tom