Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: pgilliam@us.ibm.com
Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz <drow@false.org>
Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC
Date: Thu, 01 Sep 2005 23:07:00 -0000	[thread overview]
Message-ID: <m364tkwfq7.fsf@alligator.red-bean.com> (raw)
In-Reply-To: <200508311729.12499.pgilliam@us.ibm.com> (Paul Gilliam's message of "Wed, 31 Aug 2005 17:29:12 -0700")

Paul Gilliam <pgilliam@us.ibm.com> writes:

> Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h are over 80 columns and 
> real ugly.
>
> Here, for your consideration, are two patches to change that:  one uses a short-lived macro (ppc-tdep.patch) and the other uses a
> typedef (newest.patch).

If I were to use a typedef, I'd put it in gdbarch.h and call it
gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
needs.

The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly:

enum return_value_convention (ppc_sysv_abi_return_value
                              (struct gdbarch *gdbarch,
                               struct type *valtype,
                               struct regcache *regcache,
                               gdb_byte *readbuf,
                               const gdb_byte *writebuf));

I used this once before, but Mark Kettenis declared it "weird" or
something and asked me to take it out.  :) Be that as it may, I think
it's better than the macro or the local typedef.


  reply	other threads:[~2005-09-01 23:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 21:44 Paul Gilliam
2005-08-30 21:46 ` Jim Blandy
2005-08-30 22:24   ` Daniel Jacobowitz
2005-08-30 22:30     ` Jim Blandy
2005-08-30 22:44       ` Daniel Jacobowitz
2005-08-30 23:50         ` Jim Blandy
2005-08-30 22:46       ` Stan Shebs
2005-08-30 23:36       ` Mark Kettenis
2005-08-31  7:52         ` Jim Blandy
2005-08-31 20:30   ` Paul Gilliam
2005-08-31 20:48     ` Daniel Jacobowitz
2005-09-01  0:30       ` Paul Gilliam
2005-09-01 23:07         ` Jim Blandy [this message]
2005-09-02  0:55           ` Daniel Jacobowitz
2005-09-02 14:26             ` Paul Gilliam
2005-09-06 18:14             ` Jim Blandy
2005-09-06 18:21               ` Daniel Jacobowitz
2005-09-01 18:12       ` [commit] " Paul Gilliam
2005-08-31 20:48     ` Jim Blandy
2005-08-31 20:26 ` Kevin Buettner
2005-08-31 20:32   ` Paul Gilliam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m364tkwfq7.fsf@alligator.red-bean.com \
    --to=jimb@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=pgilliam@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox