From: Daniel Jacobowitz <drow@false.org>
To: Paul Gilliam <pgilliam@us.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC
Date: Wed, 31 Aug 2005 20:48:00 -0000 [thread overview]
Message-ID: <20050831203248.GA18491@nevyn.them.org> (raw)
In-Reply-To: <200508311323.15337.pgilliam@us.ibm.com>
On Wed, Aug 31, 2005 at 01:23:15PM -0700, Paul Gilliam wrote:
> Here is the new patch with comments added/chanded in ppc-tdep.h
>
> If I hear no objections, I'll commit this tomorrow.
Kevin's OK'd it, so go ahead. But:
> 2005-08-30 Paul Gilliam <pgilliam@us.ibm.com>
>
> * ppc-tdep.h: better explanation of using -1 for nonexistant registers
> * rs6000-tdep.c (rs6000_register_reggroup_p): don't assume that
> tdep->ppc_vr0_regnum or tdep->ppc_ev0_regnum are not -1
* ppc-tdep.h (struct gdbarch_tdep): Better explanation of using
-1 for nonexistant registers.
* rs6000-tdep.c (rs6000_register_reggroup_p): Don't assume that
tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum are not -1.
> ! /* Not all PPC and RS6000 variants will have the registers
> ! represented below. A -1 is used to indicate that the register
> ! is not present in this variant. */
Two spaces after periods please, here and below. Also end comments
with periods where you didn't. Yes, I realize the file is inconsistent
about this.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-08-31 20:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 21:44 Paul Gilliam
2005-08-30 21:46 ` Jim Blandy
2005-08-30 22:24 ` Daniel Jacobowitz
2005-08-30 22:30 ` Jim Blandy
2005-08-30 22:44 ` Daniel Jacobowitz
2005-08-30 23:50 ` Jim Blandy
2005-08-30 22:46 ` Stan Shebs
2005-08-30 23:36 ` Mark Kettenis
2005-08-31 7:52 ` Jim Blandy
2005-08-31 20:30 ` Paul Gilliam
2005-08-31 20:48 ` Daniel Jacobowitz [this message]
2005-09-01 0:30 ` Paul Gilliam
2005-09-01 23:07 ` Jim Blandy
2005-09-02 0:55 ` Daniel Jacobowitz
2005-09-02 14:26 ` Paul Gilliam
2005-09-06 18:14 ` Jim Blandy
2005-09-06 18:21 ` Daniel Jacobowitz
2005-09-01 18:12 ` [commit] " Paul Gilliam
2005-08-31 20:48 ` Jim Blandy
2005-08-31 20:26 ` Kevin Buettner
2005-08-31 20:32 ` Paul Gilliam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050831203248.GA18491@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=pgilliam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox