From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11763 invoked by alias); 31 Aug 2005 20:32:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11742 invoked by uid 22791); 31 Aug 2005 20:32:51 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 31 Aug 2005 20:32:51 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EAZGK-0004pm-Vg; Wed, 31 Aug 2005 16:32:49 -0400 Date: Wed, 31 Aug 2005 20:48:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC Message-ID: <20050831203248.GA18491@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200508301459.57189.pgilliam@us.ibm.com> <200508311323.15337.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200508311323.15337.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00272.txt.bz2 On Wed, Aug 31, 2005 at 01:23:15PM -0700, Paul Gilliam wrote: > Here is the new patch with comments added/chanded in ppc-tdep.h > > If I hear no objections, I'll commit this tomorrow. Kevin's OK'd it, so go ahead. But: > 2005-08-30 Paul Gilliam > > * ppc-tdep.h: better explanation of using -1 for nonexistant registers > * rs6000-tdep.c (rs6000_register_reggroup_p): don't assume that > tdep->ppc_vr0_regnum or tdep->ppc_ev0_regnum are not -1 * ppc-tdep.h (struct gdbarch_tdep): Better explanation of using -1 for nonexistant registers. * rs6000-tdep.c (rs6000_register_reggroup_p): Don't assume that tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum are not -1. > ! /* Not all PPC and RS6000 variants will have the registers > ! represented below. A -1 is used to indicate that the register > ! is not present in this variant. */ Two spaces after periods please, here and below. Also end comments with periods where you didn't. Yes, I realize the file is inconsistent about this. -- Daniel Jacobowitz CodeSourcery, LLC