Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: fix "too much information" bug w/ "info vector" on PowerPC
Date: Tue, 30 Aug 2005 21:44:00 -0000	[thread overview]
Message-ID: <200508301459.57189.pgilliam@us.ibm.com> (raw)

Here is the problem:  When I do 'info vector', I get ALL the registers, not just the vector registers.
This happens because a test is made to see if a given register is in the vector group.   The test
compares the incoming register number against appropriate register numbers from tdep, ignoring
the fact that if, for example, there are no ev registers, the value of tdep->ppc_ev0_regnum will be
-1.  Same thing for tdep->ppc_vr0_regnum.

I was temped to commit this is obvious, but wanted the warm fuzzy of peer review.

-=# Paul #=-

2005-08-30  Paul Gilliam <pgilliam@us.ibm.com>

	* rs6000-tdep.c (rs6000_register_reggroup_p): don't assume that
        tdep->ppc_vr0_regnum or tdep->ppc_ev0_regnum are not -1


Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.241
diff -3 -c -p -r1.241 rs6000-tdep.c
*** rs6000-tdep.c       25 May 2005 03:12:13 -0000      1.241
--- rs6000-tdep.c       30 Aug 2005 21:07:25 -0000
*************** rs6000_register_reggroup_p (struct gdbar
*** 1882,1890 ****
    if (group == float_reggroup)
      return float_p;

!   vector_p = ((regnum >= tdep->ppc_vr0_regnum
               && regnum < tdep->ppc_vr0_regnum + 32)
!             || (regnum >= tdep->ppc_ev0_regnum
                  && regnum < tdep->ppc_ev0_regnum + 32)
              || regnum == tdep->ppc_vrsave_regnum
              || regnum == tdep->ppc_acc_regnum
--- 1882,1892 ----
    if (group == float_reggroup)
      return float_p;

!   vector_p = ((tdep->ppc_vr0_regnum >= 0
!                && regnum >= tdep->ppc_vr0_regnum
               && regnum < tdep->ppc_vr0_regnum + 32)
!             || (tdep->ppc_ev0_regnum >= 0
!                   && regnum >= tdep->ppc_ev0_regnum
                  && regnum < tdep->ppc_ev0_regnum + 32)
              || regnum == tdep->ppc_vrsave_regnum
              || regnum == tdep->ppc_acc_regnum


             reply	other threads:[~2005-08-30 21:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 21:44 Paul Gilliam [this message]
2005-08-30 21:46 ` Jim Blandy
2005-08-30 22:24   ` Daniel Jacobowitz
2005-08-30 22:30     ` Jim Blandy
2005-08-30 22:44       ` Daniel Jacobowitz
2005-08-30 23:50         ` Jim Blandy
2005-08-30 22:46       ` Stan Shebs
2005-08-30 23:36       ` Mark Kettenis
2005-08-31  7:52         ` Jim Blandy
2005-08-31 20:30   ` Paul Gilliam
2005-08-31 20:48     ` Daniel Jacobowitz
2005-09-01  0:30       ` Paul Gilliam
2005-09-01 23:07         ` Jim Blandy
2005-09-02  0:55           ` Daniel Jacobowitz
2005-09-02 14:26             ` Paul Gilliam
2005-09-06 18:14             ` Jim Blandy
2005-09-06 18:21               ` Daniel Jacobowitz
2005-09-01 18:12       ` [commit] " Paul Gilliam
2005-08-31 20:48     ` Jim Blandy
2005-08-31 20:26 ` Kevin Buettner
2005-08-31 20:32   ` Paul Gilliam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508301459.57189.pgilliam@us.ibm.com \
    --to=pgilliam@us.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox