From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 959 invoked by alias); 1 Sep 2005 23:07:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 672 invoked by uid 22791); 1 Sep 2005 23:07:43 -0000 Received: from nat-pool-rdu.redhat.com (HELO devserv.devel.redhat.com) (66.187.233.202) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 01 Sep 2005 23:07:43 +0000 Received: from alligator.red-bean.com.redhat.com (vpn26-22.sfbay.redhat.com [172.16.26.22]) by devserv.devel.redhat.com (8.12.11/8.12.11) with ESMTP id j81N7SAQ001670; Thu, 1 Sep 2005 19:07:36 -0400 To: pgilliam@us.ibm.com Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC References: <200508301459.57189.pgilliam@us.ibm.com> <200508311323.15337.pgilliam@us.ibm.com> <20050831203248.GA18491@nevyn.them.org> <200508311729.12499.pgilliam@us.ibm.com> From: Jim Blandy Date: Thu, 01 Sep 2005 23:07:00 -0000 In-Reply-To: <200508311729.12499.pgilliam@us.ibm.com> (Paul Gilliam's message of "Wed, 31 Aug 2005 17:29:12 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-09/txt/msg00006.txt.bz2 Paul Gilliam writes: > Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h are over 80 columns and > real ugly. > > Here, for your consideration, are two patches to change that: one uses a short-lived macro (ppc-tdep.patch) and the other uses a > typedef (newest.patch). If I were to use a typedef, I'd put it in gdbarch.h and call it gdb_retval_convention_t; there's nothing special about ppc-tdep.h's needs. The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly: enum return_value_convention (ppc_sysv_abi_return_value (struct gdbarch *gdbarch, struct type *valtype, struct regcache *regcache, gdb_byte *readbuf, const gdb_byte *writebuf)); I used this once before, but Mark Kettenis declared it "weird" or something and asked me to take it out. :) Be that as it may, I think it's better than the macro or the local typedef.