[commit/obvious] Add "volatile" keyword to "struct gdb_exception" declaration

[commit/obvious] Add "volatile" keyword to "struct gdb_exception" declaration

[Sergio Durigan Junior]

Hi,

This patch adds the "volatile" keyword to the declaration of "struct
gdb_exception" in two places that were missing it.

Checked in as obvious.

  https://sourceware.org/ml/gdb-cvs/2014-01/msg00095.html

-- 
Sergio

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Fri Jan 17 19:39:57 2014 -0200

    Add "volatile" keyword to "struct gdb_exception" declaration
    
    While doing something else, I found that those 2 places were incorrectly
    declaring a "struct gdb_exception" without using the "volatile" keyword.
    This commit fixes that.
    
    2014-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
    
    	* breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct
    	gdb_exception" declaration.
    	* remote.c (getpkt_or_notif_sane): Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a19de9f..28e8f6a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2014-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct
+	gdb_exception" declaration.
+	* remote.c (getpkt_or_notif_sane): Likewise.
+
 2014-01-17  Doug Evans  <dje@google.com>
 
 	* common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): New
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 642ffdf..c8e7e88 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2396,7 +2396,7 @@ insert_bp_location (struct bp_location *bl,
 {
   enum errors bp_err = GDB_NO_ERROR;
   const char *bp_err_message = NULL;
-  struct gdb_exception e;
+  volatile struct gdb_exception e;
 
   if (!should_be_inserted (bl) || (bl->inserted && !bl->needs_update))
     return 0;
diff --git a/gdb/remote.c b/gdb/remote.c
index e8469e3..d886929 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7873,7 +7873,7 @@ getpkt_or_notif_sane (char **buf, long *sizeof_buf, int forever,
 static void
 remote_kill (struct target_ops *ops)
 {
-  struct gdb_exception ex;
+  volatile struct gdb_exception ex;
 
   /* Catch errors so the user can quit from gdb even when we
      aren't on speaking terms with the remote system.  */

Re: [commit/obvious] Add "volatile" keyword to "struct gdb_exception" declaration

[Sergio Durigan Junior]

On Friday, January 17 2014, I wrote:

> Author: Sergio Durigan Junior <sergiodj@redhat.com>
> Date:   Fri Jan 17 19:39:57 2014 -0200
>
>     Add "volatile" keyword to "struct gdb_exception" declaration
>     
>     While doing something else, I found that those 2 places were incorrectly
>     declaring a "struct gdb_exception" without using the "volatile" keyword.
>     This commit fixes that.
>     
>     2014-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
>     
>     	* breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct
>     	gdb_exception" declaration.
>     	* remote.c (getpkt_or_notif_sane): Likewise.

Ops, Joel, sorry that I forgot to add the "gdb/" path before the
ChangeLog in the commit message.  I'll try harder to remember next
time...

-- 
Sergio