From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7279 invoked by alias); 17 Jan 2014 21:43:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7261 invoked by uid 89); 17 Jan 2014 21:43:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 21:43:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HLh8mf012410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Jan 2014 16:43:08 -0500 Received: from psique (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HLh6AG025319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 17 Jan 2014 16:43:07 -0500 From: Sergio Durigan Junior To: GDB Patches Subject: [commit/obvious] Add "volatile" keyword to "struct gdb_exception" declaration X-URL: http://www.redhat.com Date: Fri, 17 Jan 2014 21:43:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00685.txt.bz2 Hi, This patch adds the "volatile" keyword to the declaration of "struct gdb_exception" in two places that were missing it. Checked in as obvious. https://sourceware.org/ml/gdb-cvs/2014-01/msg00095.html -- Sergio Author: Sergio Durigan Junior Date: Fri Jan 17 19:39:57 2014 -0200 Add "volatile" keyword to "struct gdb_exception" declaration While doing something else, I found that those 2 places were incorrectly declaring a "struct gdb_exception" without using the "volatile" keyword. This commit fixes that. 2014-01-17 Sergio Durigan Junior * breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct gdb_exception" declaration. * remote.c (getpkt_or_notif_sane): Likewise. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a19de9f..28e8f6a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-01-17 Sergio Durigan Junior + + * breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct + gdb_exception" declaration. + * remote.c (getpkt_or_notif_sane): Likewise. + 2014-01-17 Doug Evans * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): New diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 642ffdf..c8e7e88 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -2396,7 +2396,7 @@ insert_bp_location (struct bp_location *bl, { enum errors bp_err = GDB_NO_ERROR; const char *bp_err_message = NULL; - struct gdb_exception e; + volatile struct gdb_exception e; if (!should_be_inserted (bl) || (bl->inserted && !bl->needs_update)) return 0; diff --git a/gdb/remote.c b/gdb/remote.c index e8469e3..d886929 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7873,7 +7873,7 @@ getpkt_or_notif_sane (char **buf, long *sizeof_buf, int forever, static void remote_kill (struct target_ops *ops) { - struct gdb_exception ex; + volatile struct gdb_exception ex; /* Catch errors so the user can quit from gdb even when we aren't on speaking terms with the remote system. */