From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [commit/obvious] Add "volatile" keyword to "struct gdb_exception" declaration
Date: Fri, 17 Jan 2014 21:43:00 -0000 [thread overview]
Message-ID: <m361pi709i.fsf@redhat.com> (raw)
Hi,
This patch adds the "volatile" keyword to the declaration of "struct
gdb_exception" in two places that were missing it.
Checked in as obvious.
https://sourceware.org/ml/gdb-cvs/2014-01/msg00095.html
--
Sergio
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Fri Jan 17 19:39:57 2014 -0200
Add "volatile" keyword to "struct gdb_exception" declaration
While doing something else, I found that those 2 places were incorrectly
declaring a "struct gdb_exception" without using the "volatile" keyword.
This commit fixes that.
2014-01-17 Sergio Durigan Junior <sergiodj@redhat.com>
* breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct
gdb_exception" declaration.
* remote.c (getpkt_or_notif_sane): Likewise.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a19de9f..28e8f6a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2014-01-17 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * breakpoint.c (insert_bp_location): Add "volatile" keyword to "struct
+ gdb_exception" declaration.
+ * remote.c (getpkt_or_notif_sane): Likewise.
+
2014-01-17 Doug Evans <dje@google.com>
* common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): New
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 642ffdf..c8e7e88 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2396,7 +2396,7 @@ insert_bp_location (struct bp_location *bl,
{
enum errors bp_err = GDB_NO_ERROR;
const char *bp_err_message = NULL;
- struct gdb_exception e;
+ volatile struct gdb_exception e;
if (!should_be_inserted (bl) || (bl->inserted && !bl->needs_update))
return 0;
diff --git a/gdb/remote.c b/gdb/remote.c
index e8469e3..d886929 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7873,7 +7873,7 @@ getpkt_or_notif_sane (char **buf, long *sizeof_buf, int forever,
static void
remote_kill (struct target_ops *ops)
{
- struct gdb_exception ex;
+ volatile struct gdb_exception ex;
/* Catch errors so the user can quit from gdb even when we
aren't on speaking terms with the remote system. */
next reply other threads:[~2014-01-17 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 21:43 Sergio Durigan Junior [this message]
2014-01-17 21:50 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m361pi709i.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox