Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com, vegorov@chromium.org
Subject: Re: [patch 2/2] Speed up JIT support
Date: Mon, 07 Feb 2011 15:31:00 -0000	[thread overview]
Message-ID: <m339nz275t.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTi=rEsdOUPvdnf8AEqgeFoHSF4cNegYUFk_C5Ja4@mail.gmail.com>	(Paul Pluzhnikov's message of "Fri, 4 Feb 2011 16:26:13 -0800")

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> Here is the updated patch (applies on top of the [1/2] cosmetic patch).
Paul> Re-tested on linux/x86_64, no regressions.

Thanks for doing this.

Just some nits, nothing serious.

Paul> +/* Per-objfile data private to breakpoint.c  */

Period at the end of the comment.

Paul> +  /* minimal symbol for "_ovly_debug_event" (if any)  */
Paul> +  struct minimal_symbol *overlay_msym;

Comments should start with an upper case character and end with a
period.  There are a few instances of this.

Paul> +
Paul> +static int
Paul> +msym_not_found_p (const struct minimal_symbol *msym)

This function needs an introductory comment.

This is ok with these things fixed.

Tom


  reply	other threads:[~2011-02-07 15:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 21:46 [patch 1/2] " Paul Pluzhnikov
2011-02-03 21:58 ` [patch 2/2] " Paul Pluzhnikov
2011-02-04 18:58   ` Pedro Alves
2011-02-04 20:17   ` Tom Tromey
2011-02-04 20:33     ` Paul Pluzhnikov
2011-02-05  0:26       ` Paul Pluzhnikov
2011-02-07 15:31         ` Tom Tromey [this message]
2011-02-15 21:56           ` Paul Pluzhnikov
2011-02-04 18:28 ` [patch 1/2] " Pedro Alves
2011-02-04 20:00 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339nz275t.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=ppluzhnikov@google.com \
    --cc=vegorov@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox